Re: [PATCH 2/8] badpage: keep any bad page out of circulation

Hugh Dickins
2008-12-01T23:19:50Z

On Mon, 1 Dec 2008, Christoph Lameter wrote:
> On Mon, 1 Dec 2008, Hugh Dickins wrote:
>
> > Until now the bad_page() checkers have special-cased PageReserved, keeping
> > those pages out of circulation thereafter. Now extend the special case to
> > all: we want to keep ANY page with bad state out of circulation - the
> > "free" page may well be in use by something.
>
> If I screw up with a VM patch

Oh, perish the thought!

> then my machine will now die because of OOM
> instead of letting me shutdown and reboot?

If you screw up so royally as to allocate every page in the machine
and free it with bad state, yes, that's indeed the way it will tend.
Or, to the extent that you're relying on high orders and low zones,
it will happen even sooner. Same as if you screw up and forget to
free your pages.

That's okay. In more normal cases you'll see the warnings before
it's dead, and shutdown and reboot (hopefully a different kernel!)
before it reaches that state. By the time your patches reach -mm,
I'd hope you'll have weeded out the immediate OOM cases.

Hugh