Re: [RFC][PATCH] mm: the page of MIGRATE_RESERVE don't insert into pcp

KOSAKI Motohiro
2008-12-07T08:22:50Z

>
> ====== CUT HERE ======
> From: Mel Gorman <mel@csn.ul.ie>
> Subject: [RFC] Split per-cpu list into one-list-per-migrate-type
>
> Currently the per-cpu page allocator searches the PCP list for pages of the
> correct migrate-type to reduce the possibility of pages being inappropriate
> placed from a fragmentation perspective. This search is potentially expensive
> in a fast-path and undesirable. Splitting the per-cpu list into multiple lists
> increases the size of a per-cpu structure and this was potentially a major
> problem at the time the search was introduced. These problem has been
> mitigated as now only the necessary number of structures is allocated for the
> running system.
>
> This patch replaces a list search in the per-cpu allocator with one list
> per migrate type that should be in use by the per-cpu allocator - namely
> unmovable, reclaimable and movable.
>
> Signed-off-by: Mel Gorman <mel@csn.ul.ie>

Great.

this patch works well on my box too.
and my review didn't find any bug.

very thanks.

Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>