public inbox for linux-mm@kvack.org
 help / color / mirror / Atom feed
From: Nick Piggin <npiggin@suse.de>
To: Nick Andrew <nick@nick-andrew.net>
Cc: Christoph Lameter <cl@linux-foundation.org>,
	Hugh Dickins <hugh@veritas.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Rik van Riel <riel@redhat.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] Fix incorrect use of loose in migrate.c
Date: Sat, 6 Dec 2008 13:12:27 +0100	[thread overview]
Message-ID: <20081206121227.GA6292@wotan.suse.de> (raw)
In-Reply-To: <20081205030807.32309.69191.stgit@marcab.local.tull.net>

On Fri, Dec 05, 2008 at 02:08:07PM +1100, Nick Andrew wrote:
> Fix incorrect use of loose in migrate.c
> 
> It should be 'lose', not 'loose'.
> 
> Signed-off-by: Nick Andrew <nick@nick-andrew.net>
> ---
> 
>  mm/migrate.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> 
> diff --git a/mm/migrate.c b/mm/migrate.c
> index 1e0d6b2..7605b2b 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -514,7 +514,7 @@ static int writeout(struct address_space *mapping, struct page *page)
>  	/*
>  	 * A dirty page may imply that the underlying filesystem has
>  	 * the page on some queue. So the page must be clean for
> -	 * migration. Writeout may mean we loose the lock and the
> +	 * migration. Writeout may mean we lose the lock and the
>  	 * page state is no longer what we checked for earlier.
>  	 * At this point we know that the migration attempt cannot
>  	 * be successful.

I don't know... presumably we haven't just gone and lost the little
bugger. I mean, we were holding it one minute, then... gone?  Do we
have Alzheimer's? Unlikely. I think we loosed it.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-12-06 12:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-05  3:08 [PATCH] Fix incorrect use of loose in migrate.c Nick Andrew
2008-12-06 12:12 ` Nick Piggin [this message]
2008-12-06 13:55   ` Nick Andrew
2008-12-08  3:46     ` Valdis.Kletnieks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081206121227.GA6292@wotan.suse.de \
    --to=npiggin@suse.de \
    --cc=cl@linux-foundation.org \
    --cc=hugh@veritas.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nick@nick-andrew.net \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox