From: MinChan Kim <minchan.kim@gmail.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org
Cc: npiggin@suse.de, akpm@linux-foundation.org
Subject: [PATCH] Remove needless flush_dcache_page call
Date: Fri, 16 Jan 2009 14:28:04 +0900 [thread overview]
Message-ID: <20090116052804.GA18737@barrios-desktop> (raw)
Now, Anyone don't maintain cramfs.
I don't know who is maintain romfs. so I send this patch to linux-mm,
lkml, linux-dev.
I am not sure my thought is right.
When readpage is called, page with argument in readpage is just new
allocated because kernel can't find that page in page cache.
At this time, any user process can't map the page to their address space.
so, I think D-cache aliasing probelm never occur.
It make sense ?
---
diff --git a/arch/arm/mach-integrator/clock.h b/arch/arm/mach-integrator/clock.h
deleted file mode 100644
index e69de29..0000000
diff --git a/fs/cramfs/inode.c b/fs/cramfs/inode.c
index a07338d..40c8b84 100644
--- a/fs/cramfs/inode.c
+++ b/fs/cramfs/inode.c
@@ -492,7 +492,6 @@ static int cramfs_readpage(struct file *file, struct page * page)
pgdata = kmap(page);
memset(pgdata + bytes_filled, 0, PAGE_CACHE_SIZE - bytes_filled);
kunmap(page);
- flush_dcache_page(page);
SetPageUptodate(page);
unlock_page(page);
return 0;
diff --git a/fs/romfs/inode.c b/fs/romfs/inode.c
index 98a232f..d008262 100644
--- a/fs/romfs/inode.c
+++ b/fs/romfs/inode.c
@@ -454,7 +454,6 @@ romfs_readpage(struct file *file, struct page * page)
if (!result)
SetPageUptodate(page);
- flush_dcache_page(page);
unlock_page(page);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2009-01-16 5:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-16 5:28 MinChan Kim [this message]
2009-01-16 5:33 ` [PATCH] Remove needless flush_dcache_page call Matthew Wilcox
2009-01-16 5:51 ` MinChan Kim
2009-01-16 5:57 ` Matthew Wilcox
2009-01-16 6:08 ` MinChan Kim
2009-01-16 6:13 ` Nick Piggin
2009-01-16 6:16 ` MinChan Kim
2009-01-16 5:59 ` Nick Piggin
2009-01-16 6:01 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090116052804.GA18737@barrios-desktop \
--to=minchan.kim@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).