* Question: Is zone->prev_prirotiy used ?
@ 2009-01-21 6:52 KAMEZAWA Hiroyuki
2009-01-21 7:17 ` MinChan Kim
0 siblings, 1 reply; 6+ messages in thread
From: KAMEZAWA Hiroyuki @ 2009-01-21 6:52 UTC (permalink / raw)
To: linux-mm@kvack.org; +Cc: kosaki.motohiro@jp.fujitsu.com, riel
Just a question.
In vmscan.c, zone->prev_priority doesn't seem to be used.
Is it for what, now ?
-Kame
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Question: Is zone->prev_prirotiy used ?
2009-01-21 6:52 Question: Is zone->prev_prirotiy used ? KAMEZAWA Hiroyuki
@ 2009-01-21 7:17 ` MinChan Kim
2009-01-21 23:54 ` KOSAKI Motohiro
0 siblings, 1 reply; 6+ messages in thread
From: MinChan Kim @ 2009-01-21 7:17 UTC (permalink / raw)
To: KAMEZAWA Hiroyuki
Cc: linux-mm@kvack.org, kosaki.motohiro@jp.fujitsu.com, riel
On Wed, Jan 21, 2009 at 03:52:19PM +0900, KAMEZAWA Hiroyuki wrote:
> Just a question.
>
> In vmscan.c, zone->prev_priority doesn't seem to be used.
>
> Is it for what, now ?
It's the purpose of reclaiming mapped pages before split-lru.
Now, get_scan_ratio can do it.
I think it is a meaningless variable.
How about Kosaki and Rik ?
>
> -Kame
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
Kinds Regards,
MinChan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Question: Is zone->prev_prirotiy used ?
2009-01-21 7:17 ` MinChan Kim
@ 2009-01-21 23:54 ` KOSAKI Motohiro
2009-01-22 0:06 ` KAMEZAWA Hiroyuki
0 siblings, 1 reply; 6+ messages in thread
From: KOSAKI Motohiro @ 2009-01-21 23:54 UTC (permalink / raw)
To: MinChan Kim; +Cc: kosaki.motohiro, KAMEZAWA Hiroyuki, linux-mm@kvack.org, riel
> On Wed, Jan 21, 2009 at 03:52:19PM +0900, KAMEZAWA Hiroyuki wrote:
> > Just a question.
> >
> > In vmscan.c, zone->prev_priority doesn't seem to be used.
> >
> > Is it for what, now ?
>
> It's the purpose of reclaiming mapped pages before split-lru.
> Now, get_scan_ratio can do it.
> I think it is a meaningless variable.
> How about Kosaki and Rik ?
Right.
I thought this variable can use for future enhancement.
then I didn't removed.
Kamezawa-san, does its variable prevent your development?
if so, I don't oppose removing.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Question: Is zone->prev_prirotiy used ?
2009-01-21 23:54 ` KOSAKI Motohiro
@ 2009-01-22 0:06 ` KAMEZAWA Hiroyuki
2009-01-22 0:15 ` MinChan Kim
2009-01-23 3:22 ` KOSAKI Motohiro
0 siblings, 2 replies; 6+ messages in thread
From: KAMEZAWA Hiroyuki @ 2009-01-22 0:06 UTC (permalink / raw)
To: KOSAKI Motohiro; +Cc: MinChan Kim, linux-mm@kvack.org, riel
On Thu, 22 Jan 2009 08:54:07 +0900 (JST)
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> > On Wed, Jan 21, 2009 at 03:52:19PM +0900, KAMEZAWA Hiroyuki wrote:
> > > Just a question.
> > >
> > > In vmscan.c, zone->prev_priority doesn't seem to be used.
> > >
> > > Is it for what, now ?
> >
> > It's the purpose of reclaiming mapped pages before split-lru.
> > Now, get_scan_ratio can do it.
> > I think it is a meaningless variable.
> > How about Kosaki and Rik ?
>
> Right.
> I thought this variable can use for future enhancement.
> then I didn't removed.
>
example ?
> Kamezawa-san, does its variable prevent your development?
> if so, I don't oppose removing.
>
Hmm, I tried to fix/clean up hierarchical-memory-reclaim + split-LRU and
wondered where prev_priority should be recorded (hierarchy root or local or..)
and found prev_priority is not used.
IMHO, LRU management is too complex to keep unnecessary code maintained just
because it may be used in future. I personally like to rewrite better new code
rather than reuse old ruins.
But I'm not in hurry. I just wanted to confirm.
BTW, I noticed mem_cgroup_calc_mapped_ratio() is not used, either ;)
Thanks,
-Kame
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Question: Is zone->prev_prirotiy used ?
2009-01-22 0:06 ` KAMEZAWA Hiroyuki
@ 2009-01-22 0:15 ` MinChan Kim
2009-01-23 3:22 ` KOSAKI Motohiro
1 sibling, 0 replies; 6+ messages in thread
From: MinChan Kim @ 2009-01-22 0:15 UTC (permalink / raw)
To: KAMEZAWA Hiroyuki; +Cc: KOSAKI Motohiro, linux-mm@kvack.org, riel
On Thu, Jan 22, 2009 at 09:06:57AM +0900, KAMEZAWA Hiroyuki wrote:
> On Thu, 22 Jan 2009 08:54:07 +0900 (JST)
> KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
>
> > > On Wed, Jan 21, 2009 at 03:52:19PM +0900, KAMEZAWA Hiroyuki wrote:
> > > > Just a question.
> > > >
> > > > In vmscan.c, zone->prev_priority doesn't seem to be used.
> > > >
> > > > Is it for what, now ?
> > >
> > > It's the purpose of reclaiming mapped pages before split-lru.
> > > Now, get_scan_ratio can do it.
> > > I think it is a meaningless variable.
> > > How about Kosaki and Rik ?
> >
> > Right.
> > I thought this variable can use for future enhancement.
> > then I didn't removed.
> >
> example ?
>
> > Kamezawa-san, does its variable prevent your development?
> > if so, I don't oppose removing.
> >
>
> Hmm, I tried to fix/clean up hierarchical-memory-reclaim + split-LRU and
> wondered where prev_priority should be recorded (hierarchy root or local or..)
> and found prev_priority is not used.
>
> IMHO, LRU management is too complex to keep unnecessary code maintained just
> because it may be used in future. I personally like to rewrite better new code
> rather than reuse old ruins.
I agree. It's too complicated.
I think it would be better to remove it.
We can insert it again when we will really need it.
> But I'm not in hurry. I just wanted to confirm.
>
> BTW, I noticed mem_cgroup_calc_mapped_ratio() is not used, either ;)
>
> Thanks,
> -Kame
--
Kinds Regards,
MinChan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Question: Is zone->prev_prirotiy used ?
2009-01-22 0:06 ` KAMEZAWA Hiroyuki
2009-01-22 0:15 ` MinChan Kim
@ 2009-01-23 3:22 ` KOSAKI Motohiro
1 sibling, 0 replies; 6+ messages in thread
From: KOSAKI Motohiro @ 2009-01-23 3:22 UTC (permalink / raw)
To: KAMEZAWA Hiroyuki; +Cc: kosaki.motohiro, MinChan Kim, linux-mm@kvack.org, riel
> > Kamezawa-san, does its variable prevent your development?
> > if so, I don't oppose removing.
>
> Hmm, I tried to fix/clean up hierarchical-memory-reclaim + split-LRU and
> wondered where prev_priority should be recorded (hierarchy root or local or..)
> and found prev_priority is not used.
>
> IMHO, LRU management is too complex to keep unnecessary code maintained just
> because it may be used in future. I personally like to rewrite better new code
> rather than reuse old ruins.
I can't oppose maintenar's opinion ;)
ok, I'll make the patch next week.
>
> But I'm not in hurry. I just wanted to confirm.
>
> BTW, I noticed mem_cgroup_calc_mapped_ratio() is not used, either ;)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-01-23 3:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-21 6:52 Question: Is zone->prev_prirotiy used ? KAMEZAWA Hiroyuki
2009-01-21 7:17 ` MinChan Kim
2009-01-21 23:54 ` KOSAKI Motohiro
2009-01-22 0:06 ` KAMEZAWA Hiroyuki
2009-01-22 0:15 ` MinChan Kim
2009-01-23 3:22 ` KOSAKI Motohiro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).