From: Andrew Morton <akpm@linux-foundation.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: riel@redhat.com, wli@movementarian.org,
kosaki.motohiro@jp.fujitsu.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [RFC] vmscan: initialize sc->nr_reclaimed in do_try_to_free_pages()
Date: Tue, 10 Feb 2009 14:16:13 -0800 [thread overview]
Message-ID: <20090210141613.276a3c9c.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090209222416.GA9758@cmpxchg.org>
On Mon, 9 Feb 2009 23:24:16 +0100
Johannes Weiner <hannes@cmpxchg.org> wrote:
> The commit missed to actually adjust do_try_to_free_pages() which now
> does not initialize sc.nr_reclaimed and makes shrink_zone() make
> assumptions on whether to bail out of the reclaim cycle based on an
> uninitialized value.
Both callers of do_try_to_free_pages() _do_ initialise
scan_control.nr_reclaimed. The unitemised fields in a struct
initaliser are reliably zeroed.
We often rely upon this, and the only reason for mentioning such a
field is for documentation reasons, or if you want to add a comment at
the initialisation site.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2009-02-10 22:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-09 22:24 [RFC] vmscan: initialize sc->nr_reclaimed in do_try_to_free_pages() Johannes Weiner
2009-02-10 10:47 ` MinChan Kim
2009-02-10 11:43 ` KOSAKI Motohiro
2009-02-10 12:03 ` MinChan Kim
2009-02-10 12:06 ` KOSAKI Motohiro
2009-02-10 12:31 ` MinChan Kim
2009-02-10 12:35 ` KOSAKI Motohiro
2009-02-10 12:40 ` MinChan Kim
2009-02-10 12:58 ` [PATCH] vmscan: initialize sc->nr_reclaimed properly take2 KOSAKI Motohiro
2009-02-10 13:00 ` [PATCH] shrink_all_memory() use sc.nr_reclaimed KOSAKI Motohiro
2009-02-10 16:20 ` Johannes Weiner
2009-02-10 20:41 ` KOSAKI Motohiro
2009-02-11 0:37 ` MinChan Kim
2009-02-11 11:50 ` KOSAKI Motohiro
2009-02-11 12:43 ` MinChan Kim
2009-02-11 12:58 ` KOSAKI Motohiro
2009-02-11 13:03 ` KOSAKI Motohiro
2009-02-10 16:09 ` [PATCH] vmscan: initialize sc->nr_reclaimed properly take2 Johannes Weiner
2009-02-10 22:06 ` Andrew Morton
2009-02-10 22:15 ` Johannes Weiner
2009-02-11 10:52 ` KOSAKI Motohiro
2009-02-10 22:16 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090210141613.276a3c9c.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
--cc=wli@movementarian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).