From: Alexey Dobriyan <adobriyan@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Li Zefan <lizf@cn.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [RFC][PATCH] kmemdup_from_user(): introduce
Date: Fri, 6 Mar 2009 11:57:31 +0300 [thread overview]
Message-ID: <20090306085731.GA4225@x200.localdomain> (raw)
In-Reply-To: <20090306003900.a031a914.akpm@linux-foundation.org>
On Fri, Mar 06, 2009 at 12:39:00AM -0800, Andrew Morton wrote:
> On Fri, 06 Mar 2009 16:27:53 +0800 Li Zefan <lizf@cn.fujitsu.com> wrote:
>
> > > Let's not add wrapper for every two lines that happen to be used
> > > together.
> > >
> >
> > Why not if we have good reasons? And I don't think we can call this
> > "happen to" if there are 250+ of them?
>
> The change is a good one. If a reviewer (me) sees it then you know the
> code's all right and the review effort becomes less - all you need to check
> is that the call site is using IS_ERR/PTR_ERR and isn't testing for
> NULL. Less code, less chance for bugs.
>
> Plus it makes kernel text smaller.
>
> Yes, the name is a bit cumbersome.
Some do NUL-termination afterwards and allocate "len + 1", but copy "len".
Some don't care.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-03-06 8:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-06 7:04 [RFC][PATCH] kmemdup_from_user(): introduce Li Zefan
2009-03-06 7:23 ` Américo Wang
2009-03-06 7:37 ` KOSAKI Motohiro
2009-03-06 8:03 ` KOSAKI Motohiro
2009-03-06 7:39 ` Li Zefan
2009-03-06 8:20 ` Alexey Dobriyan
2009-03-06 8:27 ` Li Zefan
2009-03-06 8:39 ` Andrew Morton
2009-03-06 8:57 ` Alexey Dobriyan [this message]
2009-03-06 9:09 ` KOSAKI Motohiro
2009-03-06 9:01 ` Li Zefan
2009-03-06 9:15 ` Andrew Morton
2009-03-06 9:49 ` [PATCH -v2] memdup_user(): introduce Li Zefan
2009-03-06 23:03 ` Andrew Morton
2009-03-07 16:48 ` Arjan van de Ven
2009-03-07 16:54 ` Roland Dreier
2009-03-07 18:27 ` Andrew Morton
2009-03-09 2:22 ` Li Zefan
2009-03-09 3:00 ` Andrew Morton
2009-03-09 3:30 ` Li Zefan
2009-03-09 3:45 ` Andrew Morton
2009-03-06 9:03 ` [RFC][PATCH] kmemdup_from_user(): introduce Alexey Dobriyan
2009-03-06 9:02 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090306085731.GA4225@x200.localdomain \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).