From: Nick Piggin <npiggin@suse.de>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Linux Memory Management List <linux-mm@kvack.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Rik van Riel <riel@redhat.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Christoph Lameter <cl@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lin Ming <ming.m.lin@intel.com>,
Zhang Yanmin <yanmin_zhang@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 00/35] Cleanup and optimise the page allocator V3
Date: Mon, 16 Mar 2009 12:45:55 +0100 [thread overview]
Message-ID: <20090316114555.GB30802@wotan.suse.de> (raw)
In-Reply-To: <1237196790-7268-1-git-send-email-mel@csn.ul.ie>
On Mon, Mar 16, 2009 at 09:45:55AM +0000, Mel Gorman wrote:
> Here is V3 of an attempt to cleanup and optimise the page allocator and should
> be ready for general testing. The page allocator is now faster (16%
> reduced time overall for kernbench on one machine) and it has a smaller cache
> footprint (16.5% less L1 cache misses and 19.5% less L2 cache misses for
> kernbench on one machine). The text footprint has unfortunately increased,
> largely due to the introduction of a form of lazy buddy merging mechanism
> that avoids cache misses by postponing buddy merging until a high-order
> allocation needs it.
BTW. I would feel better about this if it gets merged in stages, with
functional changes split out, and also code optimisations and omore
obvious performace improvements split out and preferably merged first.
At a very quick glance, the first 25 or so patches should go in first,
and that gives a much better base to compare subsequent functional
changes with. Patch 18 for example is really significant, and should
almost be 2.6.29/-stable material IMO.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-03-16 11:46 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-16 9:45 [PATCH 00/35] Cleanup and optimise the page allocator V3 Mel Gorman
2009-03-16 9:45 ` [PATCH 01/35] Replace __alloc_pages_internal() with __alloc_pages_nodemask() Mel Gorman
2009-03-16 15:49 ` Christoph Lameter
2009-03-16 9:45 ` [PATCH 02/35] Do not sanity check order in the fast path Mel Gorman
2009-03-16 15:52 ` Christoph Lameter
2009-03-16 9:45 ` [PATCH 03/35] Do not check NUMA node ID when the caller knows the node is valid Mel Gorman
2009-03-16 9:45 ` [PATCH 04/35] Check only once if the zonelist is suitable for the allocation Mel Gorman
2009-03-16 9:46 ` [PATCH 05/35] Break up the allocator entry point into fast and slow paths Mel Gorman
2009-03-16 9:46 ` [PATCH 06/35] Move check for disabled anti-fragmentation out of fastpath Mel Gorman
2009-03-16 15:54 ` Christoph Lameter
2009-03-16 9:46 ` [PATCH 07/35] Check in advance if the zonelist needs additional filtering Mel Gorman
2009-03-16 9:46 ` [PATCH 08/35] Calculate the preferred zone for allocation only once Mel Gorman
2009-03-16 9:46 ` [PATCH 09/35] Calculate the migratetype " Mel Gorman
2009-03-16 9:46 ` [PATCH 10/35] Calculate the alloc_flags " Mel Gorman
2009-03-16 9:46 ` [PATCH 11/35] Calculate the cold parameter " Mel Gorman
2009-03-16 9:46 ` [PATCH 12/35] Remove a branch by assuming __GFP_HIGH == ALLOC_HIGH Mel Gorman
2009-03-16 9:46 ` [PATCH 13/35] Inline __rmqueue_smallest() Mel Gorman
2009-03-16 9:46 ` [PATCH 14/35] Inline buffered_rmqueue() Mel Gorman
2009-03-16 9:46 ` [PATCH 15/35] Inline __rmqueue_fallback() Mel Gorman
2009-03-16 15:57 ` Christoph Lameter
2009-03-16 16:25 ` Mel Gorman
2009-03-16 9:46 ` [PATCH 16/35] Save text by reducing call sites of __rmqueue() Mel Gorman
2009-03-16 9:46 ` [PATCH 17/35] Do not call get_pageblock_migratetype() more than necessary Mel Gorman
2009-03-16 16:00 ` Christoph Lameter
2009-03-16 9:46 ` [PATCH 18/35] Do not disable interrupts in free_page_mlock() Mel Gorman
2009-03-16 16:05 ` Christoph Lameter
2009-03-16 16:29 ` Mel Gorman
2009-03-16 9:46 ` [PATCH 19/35] Do not setup zonelist cache when there is only one node Mel Gorman
2009-03-16 16:06 ` Christoph Lameter
2009-03-16 9:46 ` [PATCH 20/35] Use a pre-calculated value for num_online_nodes() Mel Gorman
2009-03-16 11:42 ` Nick Piggin
2009-03-16 11:46 ` Nick Piggin
2009-03-16 16:08 ` Christoph Lameter
2009-03-16 16:36 ` Mel Gorman
2009-03-16 16:47 ` Christoph Lameter
2009-03-18 15:08 ` Mel Gorman
2009-03-18 16:58 ` Christoph Lameter
2009-03-18 18:01 ` Mel Gorman
2009-03-18 19:10 ` Christoph Lameter
2009-03-19 20:43 ` Christoph Lameter
2009-03-19 21:29 ` Mel Gorman
2009-03-19 22:22 ` Christoph Lameter
2009-03-19 22:33 ` Mel Gorman
2009-03-19 22:42 ` Christoph Lameter
2009-03-19 22:52 ` Mel Gorman
2009-03-19 22:06 ` Mel Gorman
2009-03-19 22:39 ` Christoph Lameter
2009-03-19 22:21 ` Mel Gorman
2009-03-19 22:24 ` Christoph Lameter
2009-03-19 23:04 ` Mel Gorman
2009-03-16 9:46 ` [PATCH 21/35] Do not check for compound pages during the page allocator sanity checks Mel Gorman
2009-03-16 16:09 ` Christoph Lameter
2009-03-16 9:46 ` [PATCH 22/35] Use allocation flags as an index to the zone watermark Mel Gorman
2009-03-16 16:11 ` Christoph Lameter
2009-03-16 9:46 ` [PATCH 23/35] Update NR_FREE_PAGES only as necessary Mel Gorman
2009-03-16 16:17 ` Christoph Lameter
2009-03-16 16:42 ` Mel Gorman
2009-03-16 16:48 ` Christoph Lameter
2009-03-16 16:58 ` Mel Gorman
2009-03-16 9:46 ` [PATCH 24/35] Convert gfp_zone() to use a table of precalculated values Mel Gorman
2009-03-16 16:19 ` Christoph Lameter
2009-03-16 16:45 ` Mel Gorman
2009-03-16 9:46 ` [PATCH 25/35] Re-sort GFP flags and fix whitespace alignment for easier reading Mel Gorman
2009-03-16 9:46 ` [PATCH 26/35] Use the per-cpu allocator for orders up to PAGE_ALLOC_COSTLY_ORDER Mel Gorman
2009-03-16 16:26 ` Christoph Lameter
2009-03-16 16:47 ` Mel Gorman
2009-03-16 9:46 ` [PATCH 27/35] Split per-cpu list into one-list-per-migrate-type Mel Gorman
2009-03-16 9:46 ` [PATCH 28/35] Batch free pages from migratetype per-cpu lists Mel Gorman
2009-03-16 9:46 ` [PATCH 29/35] Do not store the PCP high and batch watermarks in the per-cpu structure Mel Gorman
2009-03-16 16:30 ` Christoph Lameter
2009-03-16 9:46 ` [PATCH 30/35] Skip the PCP list search by counting the order and type of pages on list Mel Gorman
2009-03-16 16:31 ` Christoph Lameter
2009-03-16 16:51 ` Mel Gorman
2009-03-16 9:46 ` [PATCH 31/35] Optimistically check the first page on the PCP free list is suitable Mel Gorman
2009-03-16 16:33 ` Christoph Lameter
2009-03-16 16:52 ` Mel Gorman
2009-03-16 9:46 ` [PATCH 32/35] Inline next_zones_zonelist() of the zonelist scan in the fastpath Mel Gorman
2009-03-16 9:46 ` [PATCH 33/35] Do not merge buddies until they are needed by a high-order allocation or anti-fragmentation Mel Gorman
2009-03-16 9:46 ` [PATCH 34/35] Allow compound pages to be stored on the PCP lists Mel Gorman
2009-03-16 16:47 ` Christoph Lameter
2009-03-16 9:46 ` [PATCH 35/35] Allow up to 4MB PCP lists due to compound pages Mel Gorman
2009-03-16 10:40 ` [PATCH 00/35] Cleanup and optimise the page allocator V3 Nick Piggin
2009-03-16 11:19 ` Mel Gorman
2009-03-16 11:33 ` Nick Piggin
2009-03-16 12:02 ` Mel Gorman
2009-03-16 12:25 ` Nick Piggin
2009-03-16 13:32 ` Mel Gorman
2009-03-16 15:53 ` Nick Piggin
2009-03-16 16:56 ` Mel Gorman
2009-03-16 17:05 ` Nick Piggin
2009-03-18 15:07 ` Mel Gorman
2009-03-16 11:45 ` Nick Piggin [this message]
2009-03-16 12:11 ` Mel Gorman
2009-03-16 12:28 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090316114555.GB30802@wotan.suse.de \
--to=npiggin@suse.de \
--cc=cl@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=ming.m.lin@intel.com \
--cc=penberg@cs.helsinki.fi \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).