Re: [PATCH 4/4] Memory controller soft limit reclaim on contention (v6)

[Balbir Singh <balbir@linux.vnet.ibm.com>]

* KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> [2009-03-18 09:07:47]:

> On Mon, 16 Mar 2009 14:05:12 +0530
> Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> > > > +				next_mem =
> > > > +					__mem_cgroup_largest_soft_limit_node();
> > > > +			} while (next_mem == mem);
> > > > +		}
> > > > +		mem->usage_in_excess = res_counter_soft_limit_excess(&mem->res);
> > > > +		__mem_cgroup_remove_exceeded(mem);
> > > > +		if (mem->usage_in_excess)
> > > > +			__mem_cgroup_insert_exceeded(mem);
> > > 
> > > If next_mem == NULL here, (means "mem" is an only mem_cgroup which excess softlimit.)
> > > mem will be found again even if !reclaimed.
> > > plz check.
> > 
> > Yes, We need to add a if (!next_mem) break; Thanks!
> > 
> Plz be sure that there can be following case.
> 
>   1. several memcg is over softlimit.
>   2. almost all memory usage comes from ANON or tmpfile/shmem.
>   3. Swapless system
>      or
>      Most of memory are mlocked.
>

Good point, will test with those as well. 

-- 
	Balbir

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>