From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with ESMTP id 84DA25F0001 for ; Wed, 8 Apr 2009 02:48:21 -0400 (EDT) Date: Wed, 8 Apr 2009 08:51:21 +0200 From: Andi Kleen Subject: Re: [PATCH] [3/16] POISON: Handle poisoned pages in page free Message-ID: <20090408065121.GI17934@one.firstfloor.org> References: <20090407509.382219156@firstfloor.org> <20090407150959.C099D1D046E@basil.firstfloor.org> <28c262360904071621j5bdd8e33u1fbd8534d177a941@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <28c262360904071621j5bdd8e33u1fbd8534d177a941@mail.gmail.com> Sender: owner-linux-mm@kvack.org To: Minchan Kim Cc: Andi Kleen , linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org List-ID: > > > > /* > > + * Page may have been marked bad before process is freeing it. > > + * Make sure it is not put back into the free page lists. > > + */ > > + if (PagePoison(page)) { > > + /* check more flags here... */ > > How about adding WARNING with some information(ex, pfn, flags..). The memory_failure() code is already quite chatty. Don't think more noise is needed currently. Or are you worrying about the case where a page gets corrupted by software and suddenly has Poison bits set? (e.g. 0xff everywhere). That would deserve a printk, but I'm not sure how to reliably test for that. After all a lot of flag combinations are valid. -Andi -- ak@linux.intel.com -- Speaking for myself only. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org