From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
"lizf@cn.fujitsu.com" <lizf@cn.fujitsu.com>,
Rik van Riel <riel@surriel.com>,
Bharata B Rao <bharata.rao@in.ibm.com>,
Dhaval Giani <dhaval@linux.vnet.ibm.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFI] Shared accounting for memory resource controller
Date: Wed, 8 Apr 2009 12:34:01 +0530 [thread overview]
Message-ID: <20090408070401.GC7082@balbir.in.ibm.com> (raw)
In-Reply-To: <20090408151529.fd6626c2.kamezawa.hiroyu@jp.fujitsu.com>
* KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> [2009-04-08 15:15:29]:
> On Wed, 8 Apr 2009 10:59:04 +0530
> Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>
>
> > > no serious intention.
> > > Just because you wrote "expect the user to account all cached pages as shared" ;)
> > >
> >
> > OK, I noticed another thing, our RSS accounting is not RSS per-se, it
> > includes only anon RSS, file backed pages are accounted as cached.
> > I'll send out a patch to see if we can include anon RSS as well.
> >
>
> I think we can't do it in memcg layer without new-hook because file caches
> are added to radix-tree before mapped.
>
> mm struct has anon_rss and file_rss coutners. Then, you can show
> sum of total maps of file pages. maybe.
>
Yes, correct and that is a hook worth adding, IMHO. Better statistics
are critical and it will also help us with the shared memory
accounting. Without that we can't account for file rss in the memory
cgroup.
--
Balbir
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-04-08 7:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-07 6:37 [RFI] Shared accounting for memory resource controller Balbir Singh
2009-04-07 7:00 ` KAMEZAWA Hiroyuki
2009-04-07 7:18 ` Balbir Singh
2009-04-07 7:33 ` KAMEZAWA Hiroyuki
2009-04-07 8:03 ` Balbir Singh
2009-04-07 8:24 ` KAMEZAWA Hiroyuki
2009-04-07 10:10 ` Balbir Singh
2009-04-08 5:29 ` Balbir Singh
2009-04-08 6:15 ` KAMEZAWA Hiroyuki
2009-04-08 7:04 ` Balbir Singh [this message]
2009-04-08 7:07 ` KAMEZAWA Hiroyuki
2009-04-08 7:11 ` Balbir Singh
2009-04-08 7:18 ` KAMEZAWA Hiroyuki
2009-04-08 7:31 ` Bharata B Rao
2009-04-08 7:34 ` KAMEZAWA Hiroyuki
2009-04-08 7:45 ` Bharata B Rao
2009-04-08 7:52 ` Dhaval Giani
2009-04-08 7:39 ` KAMEZAWA Hiroyuki
2009-04-08 7:48 ` Balbir Singh
2009-04-08 8:03 ` KAMEZAWA Hiroyuki
2009-04-08 8:49 ` Balbir Singh
2009-04-08 8:54 ` KAMEZAWA Hiroyuki
2009-04-08 9:02 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090408070401.GC7082@balbir.in.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=bharata.rao@in.ibm.com \
--cc=dhaval@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=riel@surriel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).