From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Dave Hansen <dave@linux.vnet.ibm.com>,
linux-mm <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Eric B Munson <ebmunson@us.ibm.com>,
Mel Gorman <mel@linux.vnet.ibm.com>,
Christoph Lameter <cl@linux-foundation.org>
Subject: Re: meminfo Committed_AS underflows
Date: Wed, 15 Apr 2009 09:04:55 +0530 [thread overview]
Message-ID: <20090415033455.GS7082@balbir.in.ibm.com> (raw)
In-Reply-To: <20090415105033.AC29.A69D9226@jp.fujitsu.com>
* KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> [2009-04-15 11:04:59]:
> committed = atomic_long_read(&vm_committed_space);
> + if (committed < 0)
> + committed = 0;
Isn't this like pushing the problem under the rug?
> allowed = ((totalram_pages - hugetlb_total_pages())
> * sysctl_overcommit_ratio / 100) + total_swap_pages;
>
> Index: b/mm/swap.c
> ===================================================================
> --- a/mm/swap.c
> +++ b/mm/swap.c
> @@ -519,7 +519,7 @@ EXPORT_SYMBOL(pagevec_lookup_tag);
> * We tolerate a little inaccuracy to avoid ping-ponging the counter between
> * CPUs
> */
> -#define ACCT_THRESHOLD max(16, NR_CPUS * 2)
> +#define ACCT_THRESHOLD max_t(long, 16, num_online_cpus() * 2)
>
Hmm.. this is a one time expansion, free of CPU hotplug.
Should we use nr_cpu_ids or num_possible_cpus()?
--
Balbir
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-04-15 3:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-14 19:33 meminfo Committed_AS underflows Dave Hansen
2009-04-15 2:04 ` KOSAKI Motohiro
2009-04-15 3:34 ` Balbir Singh [this message]
2009-04-15 4:10 ` KOSAKI Motohiro
2009-04-15 8:47 ` Balbir Singh
2009-04-27 20:27 ` Andrew Morton
2009-04-28 3:07 ` KOSAKI Motohiro
2009-04-28 3:27 ` Andrew Morton
2009-04-28 4:25 ` KOSAKI Motohiro
2009-04-28 8:17 ` Dave Hansen
2009-04-15 4:12 ` KOSAKI Motohiro
2009-04-15 8:33 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090415033455.GS7082@balbir.in.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=cl@linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=ebmunson@us.ibm.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).