From: Andrew Morton <akpm@linux-foundation.org>
To: Izik Eidus <ieidus@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
linux-mm@kvack.org, avi@redhat.com, aarcange@redhat.com,
chrisw@redhat.com, mtosatti@redhat.com, hugh@veritas.com,
kamezawa.hiroyu@jp.fujitsu.com
Subject: Re: [PATCH 4/4] add ksm kernel shared memory driver.
Date: Wed, 15 Apr 2009 15:50:58 -0700 [thread overview]
Message-ID: <20090415155058.9e4635b2.akpm@linux-foundation.org> (raw)
In-Reply-To: <49E661A5.8050305@redhat.com>
On Thu, 16 Apr 2009 01:37:25 +0300
Izik Eidus <ieidus@redhat.com> wrote:
> Andrew Morton wrote:
> > On Thu, 9 Apr 2009 06:58:41 +0300
> > Izik Eidus <ieidus@redhat.com> wrote:
> >
> >
> >
> > Confused. In the covering email you indicated that v2 of the patchset
> > had abandoned ioctls and had moved the interface to sysfs.
> >
> We have abandoned the ioctls that control the ksm behavior (how much cpu
> it take, how much kernel pages it may allocate and so on...)
> But we still use ioctls to register the application memory to be used
> with ksm.
hm. ioctls make kernel people weep and gnash teeth.
An appropriate interface would be to add new syscalls. But as ksm is
an optional thing and can even be modprobed, that doesn't work. And
having a driver in mm/ which can be modprobed is kinda neat.
I can't immediately think of a nicer interface. You could always poke
numbers into some pseudo-file but to me that seems as ugly, or uglier
than an ioctl (others seem to disagee).
Ho hum. Please design the ioctl interface so that it doesn't need any
compat handling if poss.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-04-15 22:55 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-09 3:58 [PATCH 0/4] ksm - dynamic page sharing driver for linux v3 Izik Eidus
2009-04-09 3:58 ` [PATCH 1/4] MMU_NOTIFIERS: add set_pte_at_notify() Izik Eidus
2009-04-09 3:58 ` [PATCH 2/4] add page_wrprotect(): write protecting page Izik Eidus
2009-04-09 3:58 ` [PATCH 3/4] add replace_page(): change the page pte is pointing to Izik Eidus
2009-04-09 3:58 ` [PATCH 4/4] add ksm kernel shared memory driver Izik Eidus
2009-04-14 22:09 ` Andrew Morton
2009-04-15 22:37 ` Izik Eidus
2009-04-15 22:50 ` Andrew Morton [this message]
2009-04-15 23:21 ` Andrea Arcangeli
2009-04-16 0:43 ` Jeremy Fitzhardinge
2009-04-16 0:57 ` Izik Eidus
2009-04-16 11:39 ` Andrea Arcangeli
2009-04-16 16:08 ` Jeremy Fitzhardinge
2009-04-18 14:58 ` Andrea Arcangeli
2009-04-14 22:09 ` [PATCH 3/4] add replace_page(): change the page pte is pointing to Andrew Morton
2009-04-15 11:25 ` Andrea Arcangeli
2009-04-15 22:48 ` Izik Eidus
2009-04-14 22:09 ` [PATCH 0/4] ksm - dynamic page sharing driver for linux v3 Andrew Morton
2009-04-16 17:55 ` Nick Piggin
2009-04-16 18:25 ` Izik Eidus
2009-04-17 7:08 ` Jared Hulbert
2009-04-21 2:59 ` Nick Piggin
-- strict thread matches above, loose matches on Subject: below --
2009-04-04 14:35 [PATCH 0/4] ksm - dynamic page sharing driver for linux v2 Izik Eidus
2009-04-04 14:35 ` [PATCH 1/4] MMU_NOTIFIERS: add set_pte_at_notify() Izik Eidus
2009-04-04 14:35 ` [PATCH 2/4] add page_wrprotect(): write protecting page Izik Eidus
2009-04-04 14:35 ` [PATCH 3/4] add replace_page(): change the page pte is pointing to Izik Eidus
2009-04-04 14:35 ` [PATCH 4/4] add ksm kernel shared memory driver Izik Eidus
2009-04-06 9:13 ` Andrey Panin
2009-04-06 10:58 ` Izik Eidus
2009-03-30 23:59 [PATCH 0/4] ksm - dynamic page sharing driver for linux Izik Eidus
2009-03-30 23:59 ` [PATCH 1/4] MMU_NOTIFIERS: add set_pte_at_notify() Izik Eidus
2009-03-30 23:59 ` [PATCH 2/4] add page_wrprotect(): write protecting page Izik Eidus
2009-03-30 23:59 ` [PATCH 3/4] add replace_page(): change the page pte is pointing to Izik Eidus
2009-03-30 23:59 ` [PATCH 4/4] add ksm kernel shared memory driver Izik Eidus
2009-03-31 2:12 ` Anthony Liguori
2009-03-31 12:24 ` Izik Eidus
2009-03-31 13:31 ` Anthony Liguori
2009-03-31 14:25 ` Andrea Arcangeli
2009-03-31 14:37 ` Anthony Liguori
2009-03-31 15:02 ` Andrea Arcangeli
2009-03-31 15:09 ` Anthony Liguori
2009-03-31 15:18 ` Andrea Arcangeli
2009-03-31 15:54 ` Anthony Liguori
2009-03-31 16:25 ` Andrea Arcangeli
2009-03-31 16:51 ` Anthony Liguori
2009-03-31 17:11 ` Andrea Arcangeli
2009-04-01 22:54 ` Izik Eidus
2009-04-02 0:31 ` Anthony Liguori
2009-04-02 0:48 ` Chris Wright
2009-04-02 1:22 ` Chris Wright
2009-04-02 2:36 ` Anthony Liguori
2009-04-02 7:24 ` Avi Kivity
2009-04-02 9:38 ` Andrea Arcangeli
2009-04-02 11:23 ` Izik Eidus
2009-03-31 2:15 ` KAMEZAWA Hiroyuki
2009-03-31 12:21 ` Izik Eidus
2009-03-31 23:57 ` KAMEZAWA Hiroyuki
2009-04-01 17:28 ` Izik Eidus
2009-03-31 20:52 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090415155058.9e4635b2.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=avi@redhat.com \
--cc=chrisw@redhat.com \
--cc=hugh@veritas.com \
--cc=ieidus@redhat.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).