From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with ESMTP id 5929A6B003D for ; Tue, 21 Apr 2009 06:11:08 -0400 (EDT) Date: Tue, 21 Apr 2009 11:11:15 +0100 From: Mel Gorman Subject: Re: [PATCH 13/25] Inline __rmqueue_smallest() Message-ID: <20090421101115.GP12713@csn.ul.ie> References: <1240266011-11140-1-git-send-email-mel@csn.ul.ie> <1240266011-11140-14-git-send-email-mel@csn.ul.ie> <20090421185025.F156.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20090421185025.F156.A69D9226@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org To: KOSAKI Motohiro Cc: Linux Memory Management List , Christoph Lameter , Nick Piggin , Linux Kernel Mailing List , Lin Ming , Zhang Yanmin , Peter Zijlstra , Pekka Enberg , Andrew Morton List-ID: On Tue, Apr 21, 2009 at 06:52:28PM +0900, KOSAKI Motohiro wrote: > > Inline __rmqueue_smallest by altering flow very slightly so that there > > is only one call site. This allows the function to be inlined without > > additional text bloat. > > > > Signed-off-by: Mel Gorman > > Reviewed-by: Christoph Lameter > > --- > > mm/page_alloc.c | 23 ++++++++++++++++++----- > > 1 files changed, 18 insertions(+), 5 deletions(-) > > > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index b13fc29..91a2cdb 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -665,7 +665,8 @@ static int prep_new_page(struct page *page, int order, gfp_t gfp_flags) > > * Go through the free lists for the given migratetype and remove > > * the smallest available page from the freelists > > */ > > -static struct page *__rmqueue_smallest(struct zone *zone, unsigned int order, > > +static inline > > +struct page *__rmqueue_smallest(struct zone *zone, unsigned int order, > > int migratetype) > > "only one caller" is one of keypoint of this patch, I think. > so, commenting is better? but it isn't blocking reason at all. > > Reviewed-by: KOSAKI Motohiro > Is this better? Inline __rmqueue_smallest by altering flow very slightly so that there is only one call site. Because there is only one call-site, this function can then be inlined without causing text bloat. I don't see a need to add a comment into the function itself as I don't think it would help any. -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org