Re: [PATCH 21/22] Use a pre-calculated value instead of num_online_nodes() in fast paths

[Mel Gorman <mel@csn.ul.ie>]

On Wed, Apr 22, 2009 at 04:04:47PM -0700, David Rientjes wrote:
> On Wed, 22 Apr 2009, Mel Gorman wrote:
> 
> > diff --git a/include/linux/nodemask.h b/include/linux/nodemask.h
> > index 848025c..474e73e 100644
> > --- a/include/linux/nodemask.h
> > +++ b/include/linux/nodemask.h
> > @@ -408,6 +408,19 @@ static inline int num_node_state(enum node_states state)
> >  #define next_online_node(nid)	next_node((nid), node_states[N_ONLINE])
> >  
> >  extern int nr_node_ids;
> > +extern int nr_online_nodes;
> > +
> > +static inline void node_set_online(int nid)
> > +{
> > +	node_set_state(nid, N_ONLINE);
> > +	nr_online_nodes = num_node_state(N_ONLINE);
> > +}
> > +
> > +static inline void node_set_offline(int nid)
> > +{
> > +	node_clear_state(nid, N_ONLINE);
> > +	nr_online_nodes = num_node_state(N_ONLINE);
> > +}
> >  #else
> >  
> >  static inline int node_state(int node, enum node_states state)
> 
> The later #define's of node_set_online() and node_set_offline() in 
> include/linux/nodemask.h should probably be removed now.
> 

You'd think, but you can enable memory hotplug without NUMA and
node_set_online() is called when adding memory. Even though those
functions are nops on !NUMA, they're necessary.

-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>