From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [BUGFIX][PATCH] memcg: fix try_get_mem_cgroup_from_swapcache()
Date: Mon, 27 Apr 2009 12:23:58 +0530 [thread overview]
Message-ID: <20090427065358.GB4454@balbir.in.ibm.com> (raw)
In-Reply-To: <20090427095100.29173bc1.nishimura@mxp.nes.nec.co.jp>
* nishimura@mxp.nes.nec.co.jp <nishimura@mxp.nes.nec.co.jp> [2009-04-27 09:51:00]:
> From: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
>
> memcg: fix try_get_mem_cgroup_from_swapcache()
>
> This is a bugfix for commit 3c776e64660028236313f0e54f3a9945764422df(included 2.6.30-rc1).
> Used bit of swapcache is solid under page lock, but considering move_account,
> pc->mem_cgroup is not.
>
> We need lock_page_cgroup() anyway.
>
> Signed-off-by: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
I think we need to start documenting the locks the
page_cgroup lock nests under.
If memcg_tasklist were a spinlock instead of mutex, could we use that
instead of page_cgroup lock, since we care only about task migration?
--
Balbir
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-04-27 6:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090426231752.36498c90.d-nishimura@mtf.biglobe.ne.jp>
2009-04-27 0:51 ` [BUGFIX][PATCH] memcg: fix try_get_mem_cgroup_from_swapcache() Daisuke Nishimura
2009-04-27 1:14 ` KAMEZAWA Hiroyuki
2009-04-27 6:53 ` Balbir Singh [this message]
2009-04-27 6:59 ` KAMEZAWA Hiroyuki
2009-04-27 7:03 ` Balbir Singh
2009-04-27 7:08 ` KAMEZAWA Hiroyuki
2009-04-27 7:17 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090427065358.GB4454@balbir.in.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).