From: Andrew Morton <akpm@linux-foundation.org>
To: balbir@linux.vnet.ibm.com
Cc: kosaki.motohiro@jp.fujitsu.com, dave@linux.vnet.ibm.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
ebmunson@us.ibm.com, mel@linux.vnet.ibm.com,
cl@linux-foundation.org
Subject: Re: meminfo Committed_AS underflows
Date: Mon, 27 Apr 2009 13:27:22 -0700 [thread overview]
Message-ID: <20090427132722.926b07f1.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090415084713.GU7082@balbir.in.ibm.com>
On Wed, 15 Apr 2009 14:17:13 +0530
Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> * KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> [2009-04-15 13:10:06]:
>
> > > * KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> [2009-04-15 11:04:59]:
> > >
> > > > committed = atomic_long_read(&vm_committed_space);
> > > > + if (committed < 0)
> > > > + committed = 0;
> > >
Is there a reason why we can't use a boring old percpu_counter for
vm_committed_space? That way the meminfo code can just use
percpu_counter_read_positive().
Or perhaps just percpu_counter_read(). The percpu_counter code does a
better job of handling large cpu counts than the
mysteriously-duplicative open-coded stuff we have there.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-04-27 20:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-14 19:33 meminfo Committed_AS underflows Dave Hansen
2009-04-15 2:04 ` KOSAKI Motohiro
2009-04-15 3:34 ` Balbir Singh
2009-04-15 4:10 ` KOSAKI Motohiro
2009-04-15 8:47 ` Balbir Singh
2009-04-27 20:27 ` Andrew Morton [this message]
2009-04-28 3:07 ` KOSAKI Motohiro
2009-04-28 3:27 ` Andrew Morton
2009-04-28 4:25 ` KOSAKI Motohiro
2009-04-28 8:17 ` Dave Hansen
2009-04-15 4:12 ` KOSAKI Motohiro
2009-04-15 8:33 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090427132722.926b07f1.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=cl@linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=ebmunson@us.ibm.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).