Re: [PATCH] use GFP_NOFS in kernel_event()

Andrew Morton
2009-04-30T21:15:44Z

On Thu, 30 Apr 2009 09:19:33 -0400
Eric Paris <eparis@redhat.com> wrote:

> > Somebody was going to fix this for us via lockdep annotation.
> >
> > <adds randomly-chosen cc>
>
> I really didn't forget this, but I can't figure out how to recreate it,
> so I don't know if my logic in the patch is sound. The patch certainly
> will shut up the complaint.

Do you think we should merge the GFP_NOFS workaround for 2.6.30 and
fix all up nicely for 2.6.31?

GFP_NOFS isn't all that bad, really - it will work sufficiently well.
Being able to switch it over to GFP_KERNEL later on is a pretty minor
optimisation. But it would be bad of us to simply forget about it, so I'd
probably end up retaining a switch-back-to-GFP_KERNEL patch in -mm with
which to periodically harrass you guys ;)