Re: [PATCH] use GFP_NOFS in kernel_event()

Andrew Morton
2009-05-01T20:33:22Z

On Fri, 01 May 2009 14:11:34 -0400
Eric Paris <eparis@redhat.com> wrote:

> On Thu, 2009-04-30 at 14:10 -0700, Andrew Morton wrote:
> > On Thu, 30 Apr 2009 09:19:33 -0400
> > Eric Paris <eparis@redhat.com> wrote:
> >
> > > > Somebody was going to fix this for us via lockdep annotation.
> > > >
> > > > <adds randomly-chosen cc>
> > >
> > > I really didn't forget this, but I can't figure out how to recreate it,
> > > so I don't know if my logic in the patch is sound. The patch certainly
> > > will shut up the complaint.
> >
> > Do you think we should merge the GFP_NOFS workaround for 2.6.30 and
> > fix all up nicely for 2.6.31?
>
> I'm all for it for 2.6.30

OK.

> although the patch really should have been
> the one that gets the audit use case too at
>
> >From me on Mar 18 Subject [PATCH] make inotify event handles use
> GFP_NOFS
>
> http://lkml.org/lkml/2009/3/18/310

I queued that as an incremental to Wu Fengguang's patch, because
inotify-use-gfp_nofs-in-kernel_event-to-work-around-a-lockdep-false-positive.patch
has a longer changelog ;)