From: npiggin@suse.de
To: penberg@cs.helsinki.fi
Cc: stable@kernel.org, linux-mm@kvack.org,
Matt Mackall <mpm@selenic.com>, Christoph Lameter <cl@linux.com>
Subject: [patch 1/3] mm: SLUB fix reclaim_state
Date: Tue, 05 May 2009 19:13:44 +1000 [thread overview]
Message-ID: <20090505091434.312182900@suse.de> (raw)
In-Reply-To: 20090505091343.706910164@suse.de
[-- Attachment #1: mm-slub-fix-reclaim_state.patch --]
[-- Type: text/plain, Size: 1185 bytes --]
SLUB does not correctly account reclaim_state.reclaimed_slab, so it will
break memory reclaim. Account it like SLAB does.
Cc: stable@kernel.org
Cc: linux-mm@kvack.org
Cc: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Matt Mackall <mpm@selenic.com>
Cc: Christoph Lameter <cl@linux.com>
Signed-off-by: Nick Piggin <npiggin@suse.de>
---
mm/slub.c | 3 +++
1 file changed, 3 insertions(+)
Index: linux-2.6/mm/slub.c
===================================================================
--- linux-2.6.orig/mm/slub.c
+++ linux-2.6/mm/slub.c
@@ -9,6 +9,7 @@
*/
#include <linux/mm.h>
+#include <linux/swap.h> /* struct reclaim_state */
#include <linux/module.h>
#include <linux/bit_spinlock.h>
#include <linux/interrupt.h>
@@ -1170,6 +1171,8 @@ static void __free_slab(struct kmem_cach
__ClearPageSlab(page);
reset_page_mapcount(page);
+ if (current->reclaim_state)
+ current->reclaim_state->reclaimed_slab += pages;
__free_pages(page, order);
}
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next parent reply other threads:[~2009-05-05 9:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090505091343.706910164@suse.de>
2009-05-05 9:13 ` npiggin [this message]
2009-05-05 13:46 ` [patch 1/3] mm: SLUB fix reclaim_state Christoph Lameter
2009-05-06 7:20 ` Pekka Enberg
2009-05-06 13:29 ` Christoph Lameter
2009-05-06 13:42 ` Nick Piggin
2009-05-07 8:50 ` Pekka Enberg
2009-05-06 16:02 ` Johannes Weiner
2009-05-06 16:34 ` Matt Mackall
2009-05-05 9:13 ` [patch 2/3] mm: SLOB " npiggin
2009-05-05 13:47 ` Christoph Lameter
2009-05-05 16:47 ` Matt Mackall
2009-05-05 9:13 ` [patch 3/3] mm: SLQB " npiggin
2009-05-05 13:47 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090505091434.312182900@suse.de \
--to=npiggin@suse.de \
--cc=cl@linux.com \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).