From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>, LMMML <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH -mmotm] mm: setup_per_zone_inactive_ratio - fix comment and make it __init
Date: Wed, 6 May 2009 11:03:23 +0400 [thread overview]
Message-ID: <20090506070323.GC4865@lenovo> (raw)
In-Reply-To: <20090506155145.e657b271.minchan.kim@barrios-desktop>
[Minchan Kim - Wed, May 06, 2009 at 03:51:45PM +0900]
| On Wed, 6 May 2009 10:19:23 +0400
| Cyrill Gorcunov <gorcunov@openvz.org> wrote:
|
| > The caller of setup_per_zone_inactive_ratio is module_init function.
|
| __init :)
|
| > No need to keep the callee after is completed as well.
| > Also fix a comment.
| >
| > CC: David Rientjes <rientjes@google.com>
| > Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
|
| Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
| I guess the comment was a typo.
Thanks Minchan. Actually it's not a typo :)
module_init function is supposed to be __initcall
function anyway. But it's confusing I could fix
changelog.
-- Cyrill
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-05-06 7:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-06 6:19 [PATCH -mmotm] mm: setup_per_zone_inactive_ratio - fix comment and make it __init Cyrill Gorcunov
2009-05-06 6:34 ` David Rientjes
2009-05-06 6:51 ` Minchan Kim
2009-05-06 7:03 ` Cyrill Gorcunov [this message]
2009-05-06 7:12 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090506070323.GC4865@lenovo \
--to=gorcunov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).