From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with ESMTP id A56176B0089 for ; Wed, 6 May 2009 09:42:03 -0400 (EDT) Date: Wed, 6 May 2009 15:42:36 +0200 From: Nick Piggin Subject: Re: [patch 1/3] mm: SLUB fix reclaim_state Message-ID: <20090506134236.GA3012@wotan.suse.de> References: <20090505091343.706910164@suse.de> <20090505091434.312182900@suse.de> <1241594430.15411.3.camel@penberg-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1241594430.15411.3.camel@penberg-laptop> Sender: owner-linux-mm@kvack.org To: Pekka Enberg Cc: stable@kernel.org, linux-mm@kvack.org, Matt Mackall , Christoph Lameter , akpm@linux-foundation.org List-ID: On Wed, May 06, 2009 at 10:20:30AM +0300, Pekka Enberg wrote: > On Tue, 2009-05-05 at 19:13 +1000, npiggin@suse.de wrote: > > plain text document attachment (mm-slub-fix-reclaim_state.patch) > > SLUB does not correctly account reclaim_state.reclaimed_slab, so it will > > break memory reclaim. Account it like SLAB does. > > > > Cc: stable@kernel.org > > Cc: linux-mm@kvack.org > > Cc: Pekka Enberg > > Cc: Matt Mackall > > Cc: Christoph Lameter > > Signed-off-by: Nick Piggin > > I have applied the patch series. I see you have cc'd stable so I assume > you want this in 2.6.30, right? This seems like a rather serious bug but Thanks. I think it makes sense to into 2.6.30. Also probably all active .stable kernels. > I wonder why we've gotten away with it for so long? Is there a test > program or a known workload that breaks without this? Well... it isn't doing what reclaim code wants, and it is differing behaviour between SLAB and SL?B, so I think it is fairly safe to merge these now. It doesn't look like too much *significant* changes to heuristics, but things will get skewed here and there. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org