From: Wu Fengguang <fengguang.wu@intel.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Andi Kleen <andi@firstfloor.org>, Matt Mackall <mpm@selenic.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH 4/7] proc: export more page flags in /proc/kpageflags
Date: Thu, 7 May 2009 10:46:56 +0800 [thread overview]
Message-ID: <20090507024656.GA12828@localhost> (raw)
In-Reply-To: <20090507114016.40ee6577.minchan.kim@barrios-desktop>
On Thu, May 07, 2009 at 10:40:16AM +0800, Minchan Kim wrote:
> On Thu, 07 May 2009 09:21:21 +0800
> Wu Fengguang <fengguang.wu@intel.com> wrote:
>
> > + * pseudo flags for the well known (anonymous) memory mapped pages
> > + */
> > + if (!PageSlab(page) && page_mapped(page))
> > + u |= 1 << KPF_MMAP;
> > + if (PageAnon(page))
> > + u |= 1 << KPF_ANON;
>
> Why do you check PageSlab on user pages ?
> Is there any case that PageSlab == true && page_mapped == true ?
Yes at least for SLUB: it reuses page->_mapcount, so page_mapped() is
meaningless for slab pages.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-05-07 2:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-07 1:21 [PATCH 0/7] export more page flags in /proc/kpageflags (take 5) Wu Fengguang
2009-05-07 1:21 ` [PATCH 1/7] mm: introduce PageHuge() for testing huge/gigantic pages Wu Fengguang
2009-05-07 1:21 ` [PATCH 2/7] slob: use PG_slab for identifying SLOB pages Wu Fengguang
2009-05-08 18:24 ` Matt Mackall
2009-05-07 1:21 ` [PATCH 3/7] proc: kpagecount/kpageflags code cleanup Wu Fengguang
2009-05-08 18:28 ` Matt Mackall
2009-05-07 1:21 ` [PATCH 4/7] proc: export more page flags in /proc/kpageflags Wu Fengguang
2009-05-07 2:04 ` Minchan Kim
2009-05-07 2:07 ` Wu Fengguang
2009-05-07 2:09 ` KOSAKI Motohiro
2009-05-07 2:20 ` Wu Fengguang
2009-05-07 2:40 ` Minchan Kim
2009-05-07 2:46 ` Wu Fengguang [this message]
2009-05-07 2:48 ` KOSAKI Motohiro
2009-05-07 3:05 ` Wu Fengguang
2009-05-07 1:21 ` [PATCH 5/7] pagemap: document clarifications Wu Fengguang
2009-05-07 1:21 ` [PATCH 6/7] pagemap: document 9 more exported page flags Wu Fengguang
2009-05-07 1:21 ` [PATCH 7/7] pagemap: add page-types tool Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090507024656.GA12828@localhost \
--to=fengguang.wu@intel.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).