From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with SMTP id 669606B003D for ; Thu, 7 May 2009 07:30:56 -0400 (EDT) Date: Thu, 7 May 2009 13:31:20 +0200 From: Andrea Arcangeli Subject: Re: [PATCH 3/6] ksm: change the KSM_REMOVE_MEMORY_REGION ioctl. Message-ID: <20090507113120.GH16078@random.random> References: <1241475935-21162-2-git-send-email-ieidus@redhat.com> <1241475935-21162-3-git-send-email-ieidus@redhat.com> <1241475935-21162-4-git-send-email-ieidus@redhat.com> <4A00DF9B.1080501@redhat.com> <4A014C7B.9080702@redhat.com> <20090506133434.GX16078@random.random> <4A019719.7030504@redhat.com> <20090506164945.GD15712@x200.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090506164945.GD15712@x200.localdomain> Sender: owner-linux-mm@kvack.org To: Chris Wright Cc: Hugh Dickins , Izik Eidus , Rik van Riel , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk, device@lanana.org, linux-mm@kvack.org, nickpiggin@yahoo.com.au List-ID: On Wed, May 06, 2009 at 09:49:45AM -0700, Chris Wright wrote: > I like merge. For madvise() approach I had used: > > +#define MADV_SHAREABLE 12 /* can share identical pages */ > +#define MADV_UNSHAREABLE 13 /* can not share identical pages > > But those are maybe better put as MADV_(UN)MERGEABLE (gets a bit confusing when > you talk of merging vmas ;-) > */ What this thing does is to create shared pages by merging equal pages... While I don't care about the naming much myself, one problem I have is that I've been writing a KSM paper for linuxsymposium and I'd like to use a nomenclature that is in sync with how this stuff should be called on lkml, to avoid confusion. So should I change the simpler word KSM with "Memory Merging feature" all over the paper? In addition I consistently use the term "shared KSM pages" often, should I rename all those instances to "merged pages"? I used the word 'merging' only when describing the operation KSM does when it creates shared pages, but never to name the generated pages themself. Thanks, Andrea -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org