From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail190.messagelabs.com (mail190.messagelabs.com [216.82.249.51]) by kanga.kvack.org (Postfix) with SMTP id 4F1B66B00BF for ; Sat, 9 May 2009 06:47:03 -0400 (EDT) Date: Sat, 9 May 2009 18:45:16 +0800 From: Wu Fengguang Subject: Re: [patch] tracing/mm: add page frame snapshot trace Message-ID: <20090509104516.GC8120@localhost> References: <20090508105320.316173813@intel.com> <20090508111031.020574236@intel.com> <20090508114742.GB17129@elte.hu> <20090508124433.GB15949@localhost> <20090509062758.GB21354@elte.hu> <20090509091325.GA7994@localhost> <20090509092431.GB13784@elte.hu> <20090509094316.GA5520@localhost> <20090509102254.GA15245@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090509102254.GA15245@elte.hu> Sender: owner-linux-mm@kvack.org To: Ingo Molnar Cc: =?utf-8?B?RnLDqWTDqXJpYw==?= Weisbecker , Steven Rostedt , Peter Zijlstra , Li Zefan , Andrew Morton , LKML , KOSAKI Motohiro , Andi Kleen , Matt Mackall , Alexey Dobriyan , "linux-mm@kvack.org" List-ID: On Sat, May 09, 2009 at 06:22:54PM +0800, Ingo Molnar wrote: > > * Wu Fengguang wrote: > > > > How about changing it from 'trigger' to 'dump_range': > > > > That's a better name! > > > > > echo "*" > /debug/tracing/objects/mm/pages/dump_range > > > > > > being a shortcut for 'dump all'? > > > > No I'm not complaining about -1. That's even better than "*", > > because the latter can easily be expanded by shell ;) > > > > > And: > > > > > > echo "1000 2000" > /debug/tracing/objects/mm/pages/dump_range > > > > > > ? > > > > Now it's much more intuitive! > > > > > The '1000' is the offset where the dumping starts, and 2000 is the > > > size of the dump. > > > > Ah the second parameter 2000 can easily be taken as "end".. > > Ok ... i've changed the name to dump_range and added your fix for > mapcount as well. I pushed it all out to -tip. Thanks. > Would you be interested in having a look at that and tweaking the > dump_range API to any variant of your liking, and sending a patch > for that? Both " " and " " (or any other > variant) would be fine IMHO. Sure. I can even volunteer the process/file page walk works :) > The lseek hack is nice (and we can keep that) but an explicit range > API would be nice, we try to keep all of ftrace scriptable. OK. Thanks, Fengguang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org