From: Sheng Yang <sheng@linux.intel.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, linux-mm <linux-mm@kvack.org>,
Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86: Extend test_and_set_bit() test_and_clean_bit() to 64 bits in X86_64
Date: Thu, 14 May 2009 11:45:05 +0800 [thread overview]
Message-ID: <200905141145.05591.sheng@linux.intel.com> (raw)
In-Reply-To: <87zldhl7ne.fsf@basil.nowhere.org>
On Wednesday 13 May 2009 16:38:29 Andi Kleen wrote:
> Sheng Yang <sheng@linux.intel.com> writes:
> > -static inline int test_and_set_bit(int nr, volatile unsigned long *addr)
> > +static inline int test_and_set_bit(long int nr, volatile unsigned long
> > *addr) {
> > int oldbit;
> >
> > - asm volatile(LOCK_PREFIX "bts %2,%1\n\t"
> > + asm volatile(LOCK_PREFIX REX_X86 "bts %2,%1\n\t"
>
> Use btsq on 64bit, then you don't need the explicit rex prefix.
Hi Andi
Well, I just think lots of "#ifdef/#else" is a little annoying here, then use
REX...
--
regards
Yang, Sheng
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-05-14 3:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-13 8:17 [PATCH] x86: Extend test_and_set_bit() test_and_clean_bit() to 64 bits in X86_64 Sheng Yang
2009-05-13 8:38 ` Andi Kleen
2009-05-14 3:45 ` Sheng Yang [this message]
2009-05-14 8:32 ` Andi Kleen
2009-05-14 14:09 ` H. Peter Anvin
2009-05-14 14:16 ` Andi Kleen
2009-05-14 14:16 ` H. Peter Anvin
2009-05-14 14:27 ` Andi Kleen
2009-05-14 14:25 ` H. Peter Anvin
2009-05-14 14:33 ` Andi Kleen
2009-05-14 14:36 ` H. Peter Anvin
2009-05-13 16:18 ` H. Peter Anvin
2009-05-13 16:55 ` H. Peter Anvin
2009-05-13 17:29 ` H. Peter Anvin
2009-05-14 3:52 ` Sheng Yang
2009-05-14 14:09 ` H. Peter Anvin
2009-05-14 13:57 ` Christoph Hellwig
2009-05-14 14:29 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905141145.05591.sheng@linux.intel.com \
--to=sheng@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).