linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	Sheng Yang <sheng@linux.intel.com>,
	linux-kernel@vger.kernel.org, linux-mm <linux-mm@kvack.org>,
	Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] x86: Extend test_and_set_bit() test_and_clean_bit() to 64 bits in X86_64
Date: Thu, 14 May 2009 16:27:49 +0200	[thread overview]
Message-ID: <20090514142749.GE10933@one.firstfloor.org> (raw)
In-Reply-To: <4A0C27AA.4010006@zytor.com>

On Thu, May 14, 2009 at 07:16:10AM -0700, H. Peter Anvin wrote:
> Andi Kleen wrote:
> >>>
> >> The right way to do it is to pass the proper type of register.
> > 
> > For the input index register you don't actually need 64bit and for the
> > value it's typically memory anyways.
> > 
> 
> If you have a 64-bit operation you have a 64-bit index register.  And
> you need a 64-bit index for it to handle over 2^31 (since it is signed.)

Pretty much all the bit ops and a few other operations currently have
2/4GB limits on x86-64. I don't think that's going to change.

In the kernel nothing is ever that big continuously anyways.

-Andi
-- 
ak@linux.intel.com -- Speaking for myself only.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-05-14 14:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-13  8:17 [PATCH] x86: Extend test_and_set_bit() test_and_clean_bit() to 64 bits in X86_64 Sheng Yang
2009-05-13  8:38 ` Andi Kleen
2009-05-14  3:45   ` Sheng Yang
2009-05-14  8:32     ` Andi Kleen
2009-05-14 14:09       ` H. Peter Anvin
2009-05-14 14:16         ` Andi Kleen
2009-05-14 14:16           ` H. Peter Anvin
2009-05-14 14:27             ` Andi Kleen [this message]
2009-05-14 14:25               ` H. Peter Anvin
2009-05-14 14:33                 ` Andi Kleen
2009-05-14 14:36                   ` H. Peter Anvin
2009-05-13 16:18 ` H. Peter Anvin
2009-05-13 16:55   ` H. Peter Anvin
2009-05-13 17:29     ` H. Peter Anvin
2009-05-14  3:52       ` Sheng Yang
2009-05-14 14:09         ` H. Peter Anvin
2009-05-14 13:57 ` Christoph Hellwig
2009-05-14 14:29   ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090514142749.GE10933@one.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@elte.hu \
    --cc=sheng@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).