[PATCH] mmtom: Prevent shrinking of active anon lru list in case of no swap space V4

[PATCH] mmtom: Prevent shrinking of active anon lru list in case of no swap space V4

[Minchan Kim]

Hi, Adnrew. 

Please, drop my previous version and merge this. 
This versoin can enhance code size and performance by GCC code optimization.
If you wnat to know it detail, please, reference to Johannes Weiner's saying in V3 thread.

Changelog since V4
 o Make to check nr_swap_pages at first. - by Hannes's advise
  o It can reduce text size and increase performance a litte bit by GCC code optimization.

Changelog since V3
 o Remove can_reclaim_anon.
 o Add nr_swap_page > 0 in only shrink_zone - By Rik's advise.
 o Change patch description.

Changelog since V2
 o Add new function - can_reclaim_anon : it tests anon_list can be reclaim.

Changelog since V1
 o Use nr_swap_pages <= 0 in shrink_active_list to prevent scanning  of active anon list.

Now shrink_zone can deactivate active anon pages even if we don't have a swap device.
Many embedded products don't have a swap device. So the deactivation of anon pages is unnecessary.

This patch prevents unnecessary deactivation of anon lru pages.
But, it doesn't prevent aging of anon pages to swap out.

Thanks for good review. Rik,Kosaki and Hannes.

Re: [PATCH] mmtom: Prevent shrinking of active anon lru list in case of no swap space V4

[Rik van Riel]

Minchan Kim wrote:

> This patch prevents unnecessary deactivation of anon lru pages.
> But, it doesn't prevent aging of anon pages to swap out.

>  Signed-off-by: barrios <minchan.kim@gmail.com>

Reviewed-by: Rik van Riel <riel@redhat.com>

-- 
All rights reversed.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mmtom: Prevent shrinking of active anon lru list in case of no swap space V4

[KOSAKI Motohiro]

> Minchan Kim wrote:
> 
> > This patch prevents unnecessary deactivation of anon lru pages.
> > But, it doesn't prevent aging of anon pages to swap out.
> 
> >  Signed-off-by: barrios <minchan.kim@gmail.com>
> 
> Reviewed-by: Rik van Riel <riel@redhat.com>

 Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>



--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mmtom: Prevent shrinking of active anon lru list in case of no swap space V4

[Johannes Weiner]

Reviewed-by: Johannes Weiner <hannes@cmpxchg.org>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

[PATCH] mmtom: Prevent shrinking of active anon lru list in case of no swap space V4

[Minchan Kim]

I repost this version with Rik and Kosaki's Reviewed-by sign and correcting my Signed-off-by.  

--

Hi, Adnrew. 

Please, drop my previous version and merge this. 
This versoin can enhance code size and performance by GCC code optimization.
If you wnat to know it detail, please, reference to Johannes Weiner's saying in V3 thread.

Changelog since V4
 o Make to check nr_swap_pages at first. - by Hannes's advise
  o It can reduce text size and increase performance a litte bit by GCC code optimization.

Changelog since V3
 o Remove can_reclaim_anon.
 o Add nr_swap_page > 0 in only shrink_zone - By Rik's advise.
 o Change patch description.

Changelog since V2
 o Add new function - can_reclaim_anon : it tests anon_list can be reclaim.

Changelog since V1
 o Use nr_swap_pages <= 0 in shrink_active_list to prevent scanning  of active anon list.

Now shrink_zone can deactivate active anon pages even if we don't have a swap device.
Many embedded products don't have a swap device. So the deactivation of anon pages is unnecessary.

This patch prevents unnecessary deactivation of anon lru pages.
But, it doesn't prevent aging of anon pages to swap out.

Thanks for good review. Rik,Kosaki and Hannes.

Signed-off-by: Minchan kim <minchan.kim@gmail.com>
Reviewed-by: Rik van Riel <riel@redhat.com>
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>

---
 mm/vmscan.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index 2f9d555..1b4ee95 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1577,7 +1577,7 @@ static void shrink_zone(int priority, struct zone *zone,
 	 * Even if we did not try to evict anon pages at all, we want to
 	 * rebalance the anon lru active/inactive ratio.
 	 */
-	if (inactive_anon_is_low(zone, sc))
+	if (nr_swap_pages > 0 && inactive_anon_is_low(zone, sc))
 		shrink_active_list(SWAP_CLUSTER_MAX, zone, sc, priority, 0);
 
 	throttle_vm_writeout(sc->gfp_mask);
-- 
1.5.4.3


-- 
Kinds Regards,
Minchan Kim 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>