Re: [PATCH] Warn if we run out of swap space

Avi Kivity
2009-06-03T17:56:47Z

Pavel Machek wrote:
> On Tue 2009-06-02 12:21:11, Avi Kivity wrote:
>
>> Pavel Machek wrote:
>>
>>> Ouch and please... don't stop useful printk() warnings just because
>>> some 'pie-in-the-sky future binary protocol'. That's what happened in
>>> ACPI land with battery critical, and it is also why I don't get
>>> battery warnings on some of my machines.
>>>
>>>
>> I don't oppose printk() on significant events (such as this) in addition
>> to a proper programmatic interface.
>>
>
> Good. So lets merge printk now, and someone can create proper
> programmatic interface? :-).
>
>

No objection here.

> (Top can already display swap usage, so I guess interface is really
> there but needs to be polled which is ugly... but maybe workable for
> this use?)

Don't say things like that where power people can hear you.

--
error compiling committee.c: too many arguments to function