From: Andrew Morton <akpm@linux-foundation.org>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Ingo Molnar <mingo@elte.hu>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
npiggin@suse.de, cl@linux-foundation.org,
torvalds@linux-foundation.org
Subject: Re: [PATCH v2] slab,slub: ignore __GFP_WAIT if we're booting or suspending
Date: Fri, 12 Jun 2009 08:30:05 -0700 [thread overview]
Message-ID: <20090612083005.56336219.akpm@linux-foundation.org> (raw)
In-Reply-To: <1244806440.30512.51.camel@penberg-laptop>
On Fri, 12 Jun 2009 14:34:00 +0300 Pekka Enberg <penberg@cs.helsinki.fi> wrote:
> +static gfp_t slab_gfp_mask __read_mostly = __GFP_BITS_MASK & ~__GFP_WAIT;
It'd be safer and saner to disable __GFP_FS and __GFP_IO as well.
Having either of those flags set without __GFP_WAIT is a somewhat
self-contradictory thing and there might be code under reclaim which
assumes that __GFP_FS|__GFP_IO implies __GFP_WAIT.
<wonders why mempool_alloc() didn't clear __GFP_FS>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-06-12 15:29 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 8:13 [PATCH 2/2] slab,slub: ignore __GFP_WAIT if we're booting or suspending Pekka J Enberg
2009-06-12 9:03 ` [PATCH v2] " Pekka J Enberg
2009-06-12 9:10 ` Ingo Molnar
2009-06-12 9:21 ` Benjamin Herrenschmidt
2009-06-12 9:24 ` Pekka Enberg
2009-06-12 9:36 ` Benjamin Herrenschmidt
2009-06-12 9:45 ` Pekka J Enberg
2009-06-12 9:58 ` Benjamin Herrenschmidt
2009-06-12 10:00 ` Pekka Enberg
2009-06-12 15:22 ` Andrew Morton
2009-06-12 9:49 ` Pekka Enberg
2009-06-12 9:52 ` Nick Piggin
2009-06-12 9:54 ` Pekka Enberg
2009-06-12 9:59 ` Benjamin Herrenschmidt
2009-06-25 4:38 ` Nick Piggin
2009-06-12 10:07 ` Ingo Molnar
2009-06-12 10:11 ` Pekka Enberg
2009-06-12 10:15 ` Nick Piggin
2009-06-12 10:30 ` Pekka J Enberg
2009-06-12 10:32 ` Pekka Enberg
2009-06-12 15:16 ` Linus Torvalds
2009-06-12 15:16 ` Pekka Enberg
2009-06-12 11:13 ` Benjamin Herrenschmidt
2009-06-12 11:24 ` Benjamin Herrenschmidt
2009-06-12 11:11 ` Benjamin Herrenschmidt
2009-06-12 11:34 ` Pekka Enberg
2009-06-12 11:41 ` Benjamin Herrenschmidt
2009-06-12 11:43 ` Pekka Enberg
2009-06-12 15:30 ` Andrew Morton [this message]
2009-06-12 21:42 ` Benjamin Herrenschmidt
2009-06-25 4:41 ` Nick Piggin
2009-06-12 11:09 ` Benjamin Herrenschmidt
2009-06-12 15:04 ` Linus Torvalds
2009-06-12 15:05 ` Pekka Enberg
2009-06-19 14:59 ` Pavel Machek
2009-06-19 22:27 ` Benjamin Herrenschmidt
2009-06-19 23:23 ` Pavel Machek
2009-06-19 23:50 ` Benjamin Herrenschmidt
2009-06-20 0:28 ` Pavel Machek
2009-06-20 2:10 ` Benjamin Herrenschmidt
2009-06-21 6:18 ` Pavel Machek
2009-06-21 9:31 ` Benjamin Herrenschmidt
2009-06-25 4:34 ` Nick Piggin
2009-06-25 9:56 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090612083005.56336219.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=npiggin@suse.de \
--cc=penberg@cs.helsinki.fi \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).