From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with SMTP id F25BB6B005A for ; Mon, 15 Jun 2009 06:28:02 -0400 (EDT) Date: Mon, 15 Jun 2009 17:56:39 +0800 From: Wu Fengguang Subject: Re: [PATCH 21/22] HWPOISON: send uevent to report memory corruption Message-ID: <20090615095639.GD6012@localhost> References: <20090615024520.786814520@intel.com> <20090615031255.278184860@intel.com> <20090615062934.GB31969@one.firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090615062934.GB31969@one.firstfloor.org> Sender: owner-linux-mm@kvack.org To: Andi Kleen Cc: Andrew Morton , LKML , Ingo Molnar , Mel Gorman , Thomas Gleixner , "H. Peter Anvin" , Peter Zijlstra , Nick Piggin , Hugh Dickins , "riel@redhat.com" , "chris.mason@oracle.com" , "linux-mm@kvack.org" List-ID: On Mon, Jun 15, 2009 at 02:29:34PM +0800, Andi Kleen wrote: > On Mon, Jun 15, 2009 at 10:45:41AM +0800, Wu Fengguang wrote: > > This allows the user space to do some flexible policies. > > For example, it may either do emergency sync/shutdown > > or to schedule reboot at some convenient time, depending > > on the severeness of the corruption. > > > > I don't think it's a good idea to export that much detailed information. > That would become a stable ABI, but might not be possible to keep > all these details stable. e.g. map count or reference count are > internal implementation details that shouldn't be exposed. > And what is an user space application to do with the inode? Run > find -inum? I had plan to export file path too, if available. But you are right, we should really think twice before exporting them. > Also we already report the event using low level logging mechanism. > in a relatively stable form. > > It's also unclear to me what an application would do with that much > detail. > > I would suggest to drop this part and the earlier flags move. > > Please only bug fixes are this stage. OK, I'll get rid of the uevent patches numbered 16-21 in the next release. Thanks, Fengguang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org