From: Mel Gorman <mel@csn.ul.ie>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Christoph Lameter <cl@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
riel@redhat.com, fengguang.wu@intel.com, linuxram@us.ibm.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH 0/3] Fix malloc() stall in zone_reclaim() and bring behaviour more in line with expectations V3
Date: Wed, 17 Jun 2009 13:03:42 +0100 [thread overview]
Message-ID: <20090617120342.GB28529@csn.ul.ie> (raw)
In-Reply-To: <20090617190204.99C6.A69D9226@jp.fujitsu.com>
On Wed, Jun 17, 2009 at 07:06:46PM +0900, KOSAKI Motohiro wrote:
> > On Tue, 16 Jun 2009, Mel Gorman wrote:
> >
> > > I don't have a particular workload in mind to be perfectly honest. I'm just not
> > > convinced of the wisdom of trying to unmap pages by default in zone_reclaim()
> > > just because the NUMA distances happen to be large.
> >
> > zone reclaim = 1 is supposed to be light weight with minimal impact. The
> > intend was just to remove potentially unused pagecache pages so that node
> > local allocations can succeed again. So lets not unmap pages.
>
> hm, At least major two zone reclaim developer disagree my patch. Thus I have to
> agree with you, because I really don't hope to ignore other developer's opnion.
>
> So, as far as I understand, the conclusion of this thread are
> - Drop my patch
> - instead, implement improvement patch of (may_unmap && page_mapped()) case
> - the documentation should be changed
> - it's my homework(?)
>
> Can you agree this?
>
Yes.
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-06-17 12:03 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-11 10:47 [PATCH 0/3] Fix malloc() stall in zone_reclaim() and bring behaviour more in line with expectations V3 Mel Gorman
2009-06-11 10:47 ` [PATCH 1/3] Properly account for the number of page cache pages zone_reclaim() can reclaim Mel Gorman
2009-06-11 11:37 ` KOSAKI Motohiro
2009-06-12 10:17 ` Mel Gorman
2009-06-15 4:51 ` KOSAKI Motohiro
2009-06-15 10:05 ` Mel Gorman
2009-06-11 10:47 ` [PATCH 2/3] Do not unconditionally treat zones that fail zone_reclaim() as full Mel Gorman
2009-06-11 13:48 ` Christoph Lameter
2009-06-12 10:36 ` Mel Gorman
2009-06-12 15:44 ` Andrew Morton
2009-06-15 10:28 ` Mel Gorman
2009-06-15 15:58 ` Andrew Morton
2009-06-11 10:47 ` [PATCH 3/3] Count the number of times zone_reclaim() scans and fails Mel Gorman
2009-06-11 11:33 ` KOSAKI Motohiro
2009-06-15 21:19 ` Andrew Morton
2009-06-16 9:05 ` Mel Gorman
2009-06-11 23:30 ` [PATCH 0/3] Fix malloc() stall in zone_reclaim() and bring behaviour more in line with expectations V3 Andrew Morton
2009-06-12 11:04 ` Mel Gorman
2009-06-12 16:08 ` Andrew Morton
2009-06-15 9:42 ` KOSAKI Motohiro
2009-06-15 10:56 ` Mel Gorman
2009-06-15 15:01 ` Christoph Lameter
2009-06-15 15:25 ` Mel Gorman
2009-06-16 12:08 ` KOSAKI Motohiro
2009-06-16 12:20 ` Mel Gorman
2009-06-16 12:30 ` KOSAKI Motohiro
2009-06-16 12:57 ` KOSAKI Motohiro
2009-06-16 13:44 ` Mel Gorman
2009-06-16 14:51 ` Christoph Lameter
2009-06-17 10:06 ` KOSAKI Motohiro
2009-06-17 12:03 ` Mel Gorman [this message]
2009-06-17 18:48 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090617120342.GB28529@csn.ul.ie \
--to=mel@csn.ul.ie \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=hannes@cmpxchg.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxram@us.ibm.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).