From: David Miller <davem@davemloft.net>
To: mel@csn.ul.ie
Cc: akpm@linux-foundation.org, mingo@elte.hu,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
htd@fancy-poultry.org
Subject: Re: [PATCH 3/3] net-dccp: Suppress warning about large allocations from DCCP
Date: Mon, 22 Jun 2009 16:15:02 -0700 (PDT) [thread overview]
Message-ID: <20090622.161502.74508182.davem@davemloft.net> (raw)
In-Reply-To: <1245685414-8979-4-git-send-email-mel@csn.ul.ie>
From: Mel Gorman <mel@csn.ul.ie>
Date: Mon, 22 Jun 2009 16:43:34 +0100
> The DCCP protocol tries to allocate some large hash tables during
> initialisation using the largest size possible. This can be larger than
> what the page allocator can provide so it prints a warning. However, the
> caller is able to handle the situation so this patch suppresses the warning.
>
> Signed-off-by: Mel Gorman <mel@csn.ul.ie>
It's probably much more appropriate to make this stuff use
alloc_large_system_hash(), like TCP does (see net/ipv4/tcp.c
tcp_init()).
All of this complicated DCCP hash table size computation code will
simply disappear. And it'll fix the warning too :-)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-06-22 23:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 15:43 [PATCH 0/3] Suppress page allocator warnings about order >= MAX_ORDER Mel Gorman
2009-06-22 15:43 ` [PATCH 1/3] page-allocator: Allow too high-order warning messages to be suppressed with __GFP_NOWARN Mel Gorman
2009-06-22 15:43 ` [PATCH 2/3] profile: Suppress warning about large allocations when profile=1 is specified Mel Gorman
2009-06-22 15:43 ` [PATCH 3/3] net-dccp: Suppress warning about large allocations from DCCP Mel Gorman
2009-06-22 23:15 ` David Miller [this message]
2009-06-23 2:39 ` Arnaldo Carvalho de Melo
2009-06-23 4:19 ` David Miller
2009-06-23 11:03 ` Eric Dumazet
2009-06-23 11:05 ` David Miller
2009-06-23 13:42 ` Arnaldo Carvalho de Melo
2009-06-23 8:48 ` Mel Gorman
-- strict thread matches above, loose matches on Subject: below --
2009-07-15 11:23 [PATCH 0/3] Suppress page allocator warnings about order >= MAX_ORDER (resend) Mel Gorman
2009-07-15 11:23 ` [PATCH 3/3] net-dccp: Suppress warning about large allocations from DCCP Mel Gorman
2009-07-15 13:56 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090622.161502.74508182.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=htd@fancy-poultry.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).