From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with ESMTP id 34E8C6B0055 for ; Mon, 20 Jul 2009 00:50:36 -0400 (EDT) Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e36.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n6K4n3ui018248 for ; Sun, 19 Jul 2009 22:49:03 -0600 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n6K4odP9264160 for ; Sun, 19 Jul 2009 22:50:39 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n6K4oc8O021836 for ; Sun, 19 Jul 2009 22:50:39 -0600 Date: Mon, 20 Jul 2009 10:20:37 +0530 From: Balbir Singh Subject: Re: [PATCH 10/10] ksm: change ksm nice level to be 5 Message-ID: <20090720045037.GA24157@balbir.in.ibm.com> Reply-To: balbir@linux.vnet.ibm.com References: <1247851850-4298-2-git-send-email-ieidus@redhat.com> <1247851850-4298-3-git-send-email-ieidus@redhat.com> <1247851850-4298-4-git-send-email-ieidus@redhat.com> <1247851850-4298-5-git-send-email-ieidus@redhat.com> <1247851850-4298-6-git-send-email-ieidus@redhat.com> <1247851850-4298-7-git-send-email-ieidus@redhat.com> <1247851850-4298-8-git-send-email-ieidus@redhat.com> <1247851850-4298-9-git-send-email-ieidus@redhat.com> <1247851850-4298-10-git-send-email-ieidus@redhat.com> <1247851850-4298-11-git-send-email-ieidus@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1247851850-4298-11-git-send-email-ieidus@redhat.com> Sender: owner-linux-mm@kvack.org To: Izik Eidus Cc: akpm@linux-foundation.org, hugh.dickins@tiscali.co.uk, aarcange@redhat.com, chrisw@redhat.com, avi@redhat.com, riel@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, nickpiggin@yahoo.com.au List-ID: * Izik Eidus [2009-07-17 20:30:50]: > From: Izik Eidus > > ksm should try not to disturb other tasks as much as possible. > > Signed-off-by: Izik Eidus > --- > mm/ksm.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/mm/ksm.c b/mm/ksm.c > index 75d7802..4afe345 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -1270,7 +1270,7 @@ static void ksm_do_scan(unsigned int scan_npages) > > static int ksm_scan_thread(void *nothing) > { > - set_user_nice(current, 0); > + set_user_nice(current, 5); Is the 5 arbitrary? Why not +19? What is the intention of this change - to run when no other task is ready to run? > > while (!kthread_should_stop()) { > if (ksm_run & KSM_RUN_MERGE) { -- Balbir -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org