Re: [PATCH] [11/19] HWPOISON: Refactor truncate to allow direct truncating of page v2

Andi Kleen
2009-08-05T14:10:01Z

> I haven't brought up the caller at this point, but IIRC you had
> the page locked and mapping confirmed at this point anyway so
> it would never be an error for your code.
>
> Probably it would be nice to just force callers to verify the page.
> Normally IMO it is much nicer and clearer to do it at the time the
> page gets locked, unless there is good reason otherwise.

Ok. I think I'll just keep it as it is for now.

The only reason I added the error code was to make truncate_inode_page
fit into .error_remove_page, but then latter I did another wrapper
so it could be removed again. But it won't hurt to have it either.

-Andi

--
ak@linux.intel.com -- Speaking for myself only.