Re: [PATCH] [11/19] HWPOISON: Refactor truncate to allow direct truncating of page v2

Andi Kleen
2009-08-05T13:46:05Z

On Wed, Aug 05, 2009 at 12:20:08PM +0200, Nick Piggin wrote:
> > truncate_complete_page(struct address_space *mapping, struct page *page)
> > {
> > if (page->mapping != mapping)
> > - return;
> > + return -EIO;
>
> Hmm, at this point, the page must have been removed from pagecache,
> so I don't know if you need to pass an error back?

It could be reused, which would be bad for us?

The final check is the page error count in the end anyways.

-Andi

--
ak@linux.intel.com -- Speaking for myself only.