Re: [rfc][patch 2/3] fs: make use of new helper functions

Christoph Hellwig
2009-07-06T16:45:43Z

On Mon, Jul 06, 2009 at 06:55:22PM +0200, Nick Piggin wrote:
>
> Update some fs code to make use of new helper functions introduced
> in the previous patch. Should be no significant change in behaviour
> (except CIFS now calls send_sig under i_lock, via inode_truncate_ok).
>
> ---
> fs/buffer.c | 10 +--------
> fs/cifs/inode.c | 51 ++++++++-----------------------------------------
> fs/fuse/dir.c | 13 +++---------
> fs/fuse/fuse_i.h | 2 -
> fs/fuse/inode.c | 10 ---------
> fs/nfs/inode.c | 52 +++++++++++---------------------------------------
> fs/ramfs/file-nommu.c | 18 ++++-------------
> 7 files changed, 33 insertions(+), 123 deletions(-)

Nice cleanup. I would recommend moving the introduction of those
helpers to this patch and make it the first in the series.