From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with SMTP id 5CE3F6B004D for ; Tue, 18 Aug 2009 07:13:31 -0400 (EDT) Date: Tue, 18 Aug 2009 19:11:25 +0800 From: Wu Fengguang Subject: Re: [RFC] respect the referenced bit of KVM guest pages? Message-ID: <20090818111125.GA20217@localhost> References: <4A87829C.4090908@redhat.com> <20090816051502.GB13740@localhost> <20090816112910.GA3208@localhost> <28c262360908170733q4bc5ddb8ob2fc976b6a468d6e@mail.gmail.com> <20090818023438.GB7958@localhost> <20090818131734.3d5bceb2.minchan.kim@barrios-desktop> <20090818093119.GA12679@localhost> <20090818185247.a4516389.minchan.kim@barrios-desktop> <20090818100031.GC16298@localhost> <28c262360908180400q361ea322o8959fd5ea5ae3217@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <28c262360908180400q361ea322o8959fd5ea5ae3217@mail.gmail.com> Sender: owner-linux-mm@kvack.org To: Minchan Kim Cc: Lee Schermerhorn , Rik van Riel , Jeff Dike , Avi Kivity , Andrea Arcangeli , "Yu, Wilfred" , "Kleen, Andi" , Hugh Dickins , Andrew Morton , Christoph Lameter , KOSAKI Motohiro , Mel Gorman , LKML , linux-mm List-ID: On Tue, Aug 18, 2009 at 07:00:48PM +0800, Minchan Kim wrote: > On Tue, Aug 18, 2009 at 7:00 PM, Wu Fengguang wrote: > > On Tue, Aug 18, 2009 at 05:52:47PM +0800, Minchan Kim wrote: > >> On Tue, 18 Aug 2009 17:31:19 +0800 > >> Wu Fengguang wrote: > >> > >> > On Tue, Aug 18, 2009 at 12:17:34PM +0800, Minchan Kim wrote: > >> > > On Tue, 18 Aug 2009 10:34:38 +0800 > >> > > Wu Fengguang wrote: > >> > > > >> > > > Minchan, > >> > > > > >> > > > On Mon, Aug 17, 2009 at 10:33:54PM +0800, Minchan Kim wrote: > >> > > > > On Sun, Aug 16, 2009 at 8:29 PM, Wu Fengguang wrote: > >> > > > > > On Sun, Aug 16, 2009 at 01:15:02PM +0800, Wu Fengguang wrote: > >> > > > > >> On Sun, Aug 16, 2009 at 11:53:00AM +0800, Rik van Riel wrote: > >> > > > > >> > Wu Fengguang wrote: > >> > > > > >> > > On Fri, Aug 07, 2009 at 05:09:55AM +0800, Jeff Dike wrote: > >> > > > > >> > >> Side question - > >> > > > > >> > >> A Is there a good reason for this to be in shrink_active_list() > >> > > > > >> > >> as opposed to __isolate_lru_page? > >> > > > > >> > >> > >> > > > > >> > >> A A A A A if (unlikely(!page_evictable(page, NULL))) { > >> > > > > >> > >> A A A A A A A A A putback_lru_page(page); > >> > > > > >> > >> A A A A A A A A A continue; > >> > > > > >> > >> A A A A A } > >> > > > > >> > >> > >> > > > > >> > >> Maybe we want to minimize the amount of code under the lru lock or > >> > > > > >> > >> avoid duplicate logic in the isolate_page functions. > >> > > > > >> > > > >> > > > > >> > > I guess the quick test means to avoid the expensive page_referenced() > >> > > > > >> > > call that follows it. But that should be mostly one shot cost - the > >> > > > > >> > > unevictable pages are unlikely to cycle in active/inactive list again > >> > > > > >> > > and again. > >> > > > > >> > > >> > > > > >> > Please read what putback_lru_page does. > >> > > > > >> > > >> > > > > >> > It moves the page onto the unevictable list, so that > >> > > > > >> > it will not end up in this scan again. > >> > > > > >> > >> > > > > >> Yes it does. I said 'mostly' because there is a small hole that an > >> > > > > >> unevictable page may be scanned but still not moved to unevictable > >> > > > > >> list: when a page is mapped in two places, the first pte has the > >> > > > > >> referenced bit set, the _second_ VMA has VM_LOCKED bit set, then > >> > > > > >> page_referenced() will return 1 and shrink_page_list() will move it > >> > > > > >> into active list instead of unevictable list. Shall we fix this rare > >> > > > > >> case? > >> > > > > > >> > > > > I think it's not a big deal. > >> > > > > >> > > > Maybe, otherwise I should bring up this issue long time before :) > >> > > > > >> > > > > As you mentioned, it's rare case so there would be few pages in active > >> > > > > list instead of unevictable list. > >> > > > > >> > > > Yes. > >> > > > > >> > > > > When next time to scan comes, we can try to move the pages into > >> > > > > unevictable list, again. > >> > > > > >> > > > Will PG_mlocked be set by then? Otherwise the situation is not likely > >> > > > to change and the VM_LOCKED pages may circulate in active/inactive > >> > > > list for countless times. > >> > > > >> > > PG_mlocked is not important in that case. > >> > > Important thing is VM_LOCKED vma. > >> > > I think below annotaion can help you to understand my point. :) > >> > > >> > Hmm, it looks like pages under VM_LOCKED vma is guaranteed to have > >> > PG_mlocked set, and so will be caught by page_evictable(). Is it? > >> > >> No. I am sorry for making my point not clear. > >> I meant following as. > >> When the next time to scan, > >> > >> shrink_page_list > > A -> > > A A A A A A A A referenced = page_referenced(page, 1, > > A A A A A A A A A A A A A A A A A A A A A A A A sc->mem_cgroup, &vm_flags); > > A A A A A A A A /* In active use or really unfreeable? A Activate it. */ > > A A A A A A A A if (sc->order <= PAGE_ALLOC_COSTLY_ORDER && > > A A A A A A A A A A A A A A A A A A A A referenced && page_mapping_inuse(page)) > > A A A A A A A A A A A A goto activate_locked; > > > >> -> try_to_unmap > > A A ~~~~~~~~~~~~ this line won't be reached if page is found to be > > A A referenced in the above lines? > > Indeed! In fact, I was worry about that. > It looks after live lock problem. > But I think it's very small race window so there isn't any report until now. > Let's Cced Lee. > > If we have to fix it, how about this ? > This version has small overhead than yours since > there is less shrink_page_list call than page_referenced. Yeah, it looks better. However I still wonder if (VM_LOCKED && !PG_mlocked) is possible and somehow persistent. Does anyone have the answer? Thanks! Thanks, Fengguang > > diff --git a/mm/rmap.c b/mm/rmap.c > index ed63894..283266c 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -358,6 +358,7 @@ static int page_referenced_one(struct page *page, > */ > if (vma->vm_flags & VM_LOCKED) { > *mapcount = 1; /* break early from loop */ > + *vm_flags |= VM_LOCKED; > goto out_unmap; > } > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index d224b28..d156e1d 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -632,7 +632,8 @@ static unsigned long shrink_page_list(struct > list_head *page_list, > sc->mem_cgroup, &vm_flags); > /* In active use or really unfreeable? Activate it. */ > if (sc->order <= PAGE_ALLOC_COSTLY_ORDER && > - referenced && page_mapping_inuse(page)) > + referenced && page_mapping_inuse(page) > + && !(vm_flags & VM_LOCKED)) > goto activate_locked; > > > > > > > Thanks, > > Fengguang > > > >> A A A -> try_to_unmap_xxx > >> A A A A A A A -> if (vma->vm_flags & VM_LOCKED) > >> A A A A A A A -> try_to_mlock_page > >> A A A A A A A A A A A -> TestSetPageMlocked > >> A A A A A A A A A A A -> putback_lru_page > >> > >> So at last, the page will be located in unevictable list. > >> > >> > Then I was worrying about a null problem. Sorry for the confusion! > >> > > >> > Thanks, > >> > Fengguang > >> > > >> > > ---- > >> > > > >> > > /* > >> > > A * called from munlock()/munmap() path with page supposedly on the LRU. > >> > > A * > >> > > A * Note: A unlike mlock_vma_page(), we can't just clear the PageMlocked > >> > > A * [in try_to_munlock()] and then attempt to isolate the page. A We must > >> > > A * isolate the page to keep others from messing with its unevictable > >> > > A * and mlocked state while trying to munlock. A However, we pre-clear the > >> > > A * mlocked state anyway as we might lose the isolation race and we might > >> > > A * not get another chance to clear PageMlocked. A If we successfully > >> > > A * isolate the page and try_to_munlock() detects other VM_LOCKED vmas > >> > > A * mapping the page, it will restore the PageMlocked state, unless the page > >> > > A * is mapped in a non-linear vma. A So, we go ahead and SetPageMlocked(), > >> > > A * perhaps redundantly. > >> > > A * If we lose the isolation race, and the page is mapped by other VM_LOCKED > >> > > A * vmas, we'll detect this in vmscan--via try_to_munlock() or try_to_unmap() > >> > > A * either of which will restore the PageMlocked state by calling > >> > > A * mlock_vma_page() above, if it can grab the vma's mmap sem. > >> > > A */ > >> > > static void munlock_vma_page(struct page *page) > >> > > { > >> > > ... > >> > > > >> > > -- > >> > > Kind regards, > >> > > Minchan Kim > >> > >> > >> -- > >> Kind regards, > >> Minchan Kim > > > > > > -- > Kind regards, > Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org