From: Christoph Hellwig <hch@lst.de>
To: Vincent Li <macli@brc.ubc.ca>
Cc: Christoph Hellwig <hch@lst.de>,
linux-mm@kvack.org, Badari Pulavarty <pbadari@us.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm/vmscan: change generic_file_write() comment to do_sync_write()
Date: Wed, 26 Aug 2009 00:50:58 +0200 [thread overview]
Message-ID: <20090825225058.GA28285@lst.de> (raw)
In-Reply-To: <alpine.DEB.2.00.0908251535070.20886@kernelhack.brc.ubc.ca>
On Tue, Aug 25, 2009 at 03:45:44PM -0700, Vincent Li wrote:
> There is no __generic_file_aio_write, but __generic_file_aio_write_nolock,
> generic_file_aio_write and generic_file_aio_write_nolock.
Indeed right now there is, but it gets renamed to
__generic_file_aio_write in a patchset queued up ;-)
>
> I read the commit 543ade1fc9, it seems it replaced all .write = generic_file_write to
> .write = do_sync_write. I thought they are the same.
That's true. But do_sync_write is just a wrapper waiting for the
.aio_write method, for which the generic_file_write equivalent is
generic_file_aio_writev which calls into the above fuction.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-08-25 22:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-25 22:18 [PATCH] mm/vmscan: change generic_file_write() comment to do_sync_write() Vincent Li
2009-08-25 22:22 ` Christoph Hellwig
2009-08-25 22:45 ` Vincent Li
2009-08-25 22:50 ` Christoph Hellwig [this message]
2009-10-16 18:43 ` [PATCH] mm/vmscan: change comment generic_file_write to __generic_file_aio_write Vincent Li
[not found] <8acda98c0908260507s7b813292i54b2d782cbfaadfe@mail.gmail.com>
2009-08-26 18:17 ` [PATCH] mm/vmscan: change generic_file_write() comment to do_sync_write() Vincent Li
2009-08-26 18:26 ` Nikita Danilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090825225058.GA28285@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=macli@brc.ubc.ca \
--cc=pbadari@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).