From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with SMTP id 80B646B005A for ; Sun, 30 Aug 2009 08:58:25 -0400 (EDT) Received: by bwz24 with SMTP id 24so1517859bwz.38 for ; Sun, 30 Aug 2009 05:58:33 -0700 (PDT) From: Bartlomiej Zolnierkiewicz Subject: Re: ipw2200: firmware DMA loading rework Date: Sun, 30 Aug 2009 14:37:42 +0200 References: <20090826074409.606b5124.akpm@linux-foundation.org> <1251430951.3704.181.camel@debian> In-Reply-To: <1251430951.3704.181.camel@debian> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <200908301437.42133.bzolnier@gmail.com> Sender: owner-linux-mm@kvack.org To: Zhu Yi Cc: Andrew Morton , Mel Gorman , Johannes Weiner , Pekka Enberg , "Rafael J. Wysocki" , Linux Kernel Mailing List , Kernel Testers List , Mel Gorman , "netdev@vger.kernel.org" , "linux-mm@kvack.org" , James Ketrenos , "Chatre, Reinette" , "linux-wireless@vger.kernel.org" , "ipw2100-devel@lists.sourceforge.net" List-ID: On Friday 28 August 2009 05:42:31 Zhu Yi wrote: > Bartlomiej Zolnierkiewicz reported an atomic order-6 allocation failure > for ipw2200 firmware loading in kernel 2.6.30. High order allocation is s/2.6.30/2.6.31-rc6/ The issue has always been there but it was some recent change that explicitly triggered the allocation failures (after 2.6.31-rc1). > likely to fail and should always be avoided. > > The patch fixes this problem by replacing the original order-6 > pci_alloc_consistent() with an array of order-1 pages from a pci pool. > This utilized the ipw2200 DMA command blocks (up to 64 slots). The > maximum firmware size support remains the same (64*8K). > > This patch fixes bug http://bugzilla.kernel.org/show_bug.cgi?id=14016 > > Cc: Andrew Morton > Cc: Mel Gorman > Signed-off-by: Zhu Yi Thanks for the fix (also kudos to other people helping with the bugreport), it works fine so far and looks OK to me: Tested-and-reviewed-by: Bartlomiej Zolnierkiewicz -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org