From: Ingo Molnar <mingo@elte.hu>
To: Robin Holt <holt@sgi.com>
Cc: tglx@linutronix.de, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Jack Steiner <steiner@sgi.com>,
Cliff Whickman <cpw@sgi.com>
Subject: Re: [patch 0/2] x86, UV: fixups for configurations with a large number of nodes.
Date: Fri, 16 Oct 2009 14:53:13 +0200 [thread overview]
Message-ID: <20091016125313.GB15393@elte.hu> (raw)
In-Reply-To: <20091016112920.GZ8903@sgi.com>
* Robin Holt <holt@sgi.com> wrote:
> > uv_nshift = uv_hub_info->m_val;
> >
> > to (in essence):
> >
> > uv_hub_info->m_val & ((1UL << uv_hub_info->n_val) - 1)
> >
> > which is not the same. Furthermore, the new inline is:
>
> You have an excellent point there. That was a bug as well. That may
> explain a few of our currently unexplained bau hangs. The value is
> supposed to be a pnode instead of the current gnode.
So ... is the commit log message i've put into the commit below correct,
or is it still only a cleanup patch? You really need to put that kind of
info into your changelogs - it helps maintainers put it into the right
kernel release.
Ingo
------------>
next prev parent reply other threads:[~2009-10-16 12:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-15 22:39 [patch 0/2] x86, UV: fixups for configurations with a large number of nodes Robin Holt
2009-10-15 22:40 ` [patch 1/2] x86, UV: Fix information in __uv_hub_info structure Robin Holt
2009-10-15 22:40 ` [patch 2/2] x86, UV: Modify bau to use uv_gpa_to_pnode() Robin Holt
2009-10-16 6:34 ` [patch 0/2] x86, UV: fixups for configurations with a large number of nodes Ingo Molnar
2009-10-16 11:29 ` Robin Holt
2009-10-16 12:53 ` Ingo Molnar [this message]
2009-10-16 14:55 ` Robin Holt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091016125313.GB15393@elte.hu \
--to=mingo@elte.hu \
--cc=cpw@sgi.com \
--cc=holt@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=steiner@sgi.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).