linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Alex Chiang <achiang@hp.com>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH 4/5] mm: add numa node symlink for cpu devices in sysfs
Date: Mon, 19 Oct 2009 15:34:30 -0600	[thread overview]
Message-ID: <20091019213430.32729.78995.stgit@bob.kio> (raw)
In-Reply-To: <20091019212740.32729.7171.stgit@bob.kio>

You can discover which CPUs belong to a NUMA node by examining
/sys/devices/system/node/$node/

However, it's not convenient to go in the other direction, when looking at
/sys/devices/system/cpu/$cpu/

Yes, you can muck about in sysfs, but adding these symlinks makes
life a lot more convenient.

Signed-off-by: Alex Chiang <achiang@hp.com>
---

 drivers/base/node.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/drivers/base/node.c b/drivers/base/node.c
index ffda067..47a4997 100644
--- a/drivers/base/node.c
+++ b/drivers/base/node.c
@@ -227,6 +227,7 @@ struct node node_devices[MAX_NUMNODES];
  */
 int register_cpu_under_node(unsigned int cpu, unsigned int nid)
 {
+	int ret;
 	struct sys_device *obj;
 
 	if (!node_online(nid))
@@ -236,9 +237,13 @@ int register_cpu_under_node(unsigned int cpu, unsigned int nid)
 	if (!obj)
 		return 0;
 
-	return sysfs_create_link(&node_devices[nid].sysdev.kobj,
+	ret = sysfs_create_link(&node_devices[nid].sysdev.kobj,
 				&obj->kobj,
 				kobject_name(&obj->kobj));
+
+	return sysfs_create_link(&obj->kobj,
+				 &node_devices[nid].sysdev.kobj,
+				 kobject_name(&node_devices[nid].sysdev.kobj));
 }
 
 int unregister_cpu_under_node(unsigned int cpu, unsigned int nid)
@@ -254,6 +259,8 @@ int unregister_cpu_under_node(unsigned int cpu, unsigned int nid)
 
 	sysfs_remove_link(&node_devices[nid].sysdev.kobj,
 			  kobject_name(&obj->kobj));
+	sysfs_remove_link(&obj->kobj,
+			  kobject_name(&node_devices[nid].sysdev.kobj));
 
 	return 0;
 }

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2009-10-19 21:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-19 21:34 [PATCH 0/5] mm: modest useability enhancements for node sysfs attrs Alex Chiang
2009-10-19 21:34 ` [PATCH 1/5] mm: add numa node symlink for memory section in sysfs Alex Chiang
2009-10-20 11:55   ` KAMEZAWA Hiroyuki
2009-10-21 18:27     ` Alex Chiang
2009-10-19 21:34 ` [PATCH 2/5] mm: refactor register_cpu_under_node() Alex Chiang
2009-10-19 21:34 ` [PATCH 3/5] mm: refactor unregister_cpu_under_node() Alex Chiang
2009-10-19 21:34 ` Alex Chiang [this message]
2009-10-20  3:18   ` [PATCH 4/5] mm: add numa node symlink for cpu devices in sysfs David Rientjes
2009-10-20 20:41     ` Alex Chiang
2009-10-20 21:09       ` David Rientjes
2009-10-21 19:30         ` Alex Chiang
2009-10-19 21:34 ` [PATCH 5/5] Documentation: ABI: document /sys/devices/system/cpu/ Alex Chiang
2009-10-20  3:28   ` David Rientjes
2009-10-20 20:47     ` Alex Chiang
2009-10-20 21:13       ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091019213430.32729.78995.stgit@bob.kio \
    --to=achiang@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).