* [PATCH] rmap : move the `out` to a more proper place
@ 2009-10-20 7:14 Huang Shijie
2009-10-20 7:28 ` Wu Fengguang
0 siblings, 1 reply; 2+ messages in thread
From: Huang Shijie @ 2009-10-20 7:14 UTC (permalink / raw)
To: akpm; +Cc: hugh.dickins, fengguang.wu, linux-mm, Huang Shijie
When the code jumps to the `out' ,the referenced is still zero.
So there is no need to check it.
Signed-off-by: Huang Shijie <shijie8@gmail.com>
---
mm/rmap.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/mm/rmap.c b/mm/rmap.c
index dd43373..fe99069 100644
--- a/mm/rmap.c
+++ b/mm/rmap.c
@@ -388,9 +388,10 @@ static int page_referenced_one(struct page *page,
out_unmap:
(*mapcount)--;
pte_unmap_unlock(pte, ptl);
-out:
+
if (referenced)
*vm_flags |= vma->vm_flags;
+out:
return referenced;
}
--
1.6.0.6
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rmap : move the `out` to a more proper place
2009-10-20 7:14 [PATCH] rmap : move the `out` to a more proper place Huang Shijie
@ 2009-10-20 7:28 ` Wu Fengguang
0 siblings, 0 replies; 2+ messages in thread
From: Wu Fengguang @ 2009-10-20 7:28 UTC (permalink / raw)
To: Huang Shijie
Cc: akpm@linux-foundation.org, hugh.dickins@tiscali.co.uk,
linux-mm@kvack.org
On Tue, Oct 20, 2009 at 03:14:19PM +0800, Huang Shijie wrote:
> When the code jumps to the `out' ,the referenced is still zero.
> So there is no need to check it.
>
> Signed-off-by: Huang Shijie <shijie8@gmail.com>
Acked-by: Wu Fengguang <fengguang.wu@intel.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-20 7:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-20 7:14 [PATCH] rmap : move the `out` to a more proper place Huang Shijie
2009-10-20 7:28 ` Wu Fengguang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).