From: Frans Pop <elendil@planet.nl>
To: Mel Gorman <mel@csn.ul.ie>
Cc: David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
stable <stable@kernel.org>, "Rafael J. Wysocki" <rjw@sisk.pl>,
David Miller <davem@davemloft.net>,
reinette chatre <reinette.chatre@intel.com>,
Kalle Valo <kalle.valo@iki.fi>,
"John W. Linville" <linville@tuxdriver.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Karol Lewandowski <karol.k.lewandowski@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH 2/2] page allocator: Direct reclaim should always obey watermarks
Date: Tue, 27 Oct 2009 22:00:04 +0100 [thread overview]
Message-ID: <200910272200.07614.elendil@planet.nl> (raw)
In-Reply-To: <200910170128.29086.elendil@planet.nl>
On Saturday 17 October 2009, Frans Pop wrote:
> On Saturday 17 October 2009, Mel Gorman wrote:
> > Frans, you reported that both patches in combination reduced the
> > number of failures. Was it in fact just the kswapd change that made
> > the difference?
>
> I will retest both patches (as I already mailed you privately
> yesterday), but not today. The improvement with the combination was
> real, but I'm not sure which patch is the reason. I think the second,
> but I need to verify.
>
> I've done another 30 boots or so today, mainly in the "akpm" merge, and
> I've found new patterns that will help me nail down the regression. But
> ATM I can't see straight anymore, so it will have to wait until
> tomorrow.
Again sorry for the delay, but I needed to retest these with various
kernels as the results were inconclusive. AFAICT neither of the two
patches makes a significant difference for my test case.
Not sure if my initial test was broken or that it was just a case where the
timings worked out favorably.
Cheers,
FJP
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-10-27 21:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-16 10:37 [PATCH 0/2] Reduce number of GFP_ATOMIC allocation failures Mel Gorman
2009-10-16 10:37 ` [PATCH 1/2] page allocator: Always wake kswapd when restarting an allocation attempt after direct reclaim failed Mel Gorman
2009-10-16 10:52 ` Pekka Enberg
2009-10-19 7:40 ` Christoph Lameter
2009-10-16 10:37 ` [PATCH 2/2] page allocator: Direct reclaim should always obey watermarks Mel Gorman
2009-10-16 19:07 ` David Rientjes
2009-10-16 22:32 ` Mel Gorman
2009-10-16 23:28 ` Frans Pop
2009-10-27 21:00 ` Frans Pop [this message]
2009-10-17 18:34 ` [PATCH 0/2] Reduce number of GFP_ATOMIC allocation failures Karol Lewandowski
2009-10-18 22:18 ` Karol Lewandowski
2009-10-18 22:31 ` Frans Pop
2009-10-19 0:36 ` Karol Lewandowski
2009-10-19 14:13 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910272200.07614.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=akpm@linux-foundation.org \
--cc=bzolnier@gmail.com \
--cc=davem@davemloft.net \
--cc=kalle.valo@iki.fi \
--cc=karol.k.lewandowski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linville@tuxdriver.com \
--cc=mel@csn.ul.ie \
--cc=netdev@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=reinette.chatre@intel.com \
--cc=rientjes@google.com \
--cc=rjw@sisk.pl \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).