Re: [RFC][PATCH 1/2] perf: Add 'perf kmem' tool

Li Zefan
2009-11-20T09:12:04Z

Ingo Molnar wrote:
> * Li Zefan <lizf@cn.fujitsu.com> wrote:
>
>> ---
>> tools/perf/Makefile | 1 +
>> tools/perf/builtin-kmem.c | 578 +++++++++++++++++++++++++++++++++++++++++++++
>> tools/perf/builtin.h | 1 +
>> tools/perf/perf.c | 27 +-
>> 4 files changed, 594 insertions(+), 13 deletions(-)
>> create mode 100644 tools/perf/builtin-kmem.c
>
> btw., you might want to add it to command-list.txt as well (in a future
> patch), so that 'kmem' shows up in the default 'perf' output.
>
> Plus a Documentation/perf-kmem.txt file will make sure that 'perf help
> kmem' and 'perf kmem --help' displays a help page, etc.
>

I planed to do these after collecting comments and getting positive
responses. So sure, I'll post further patches.