From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>, stable <stable@kernel.org>,
David Rientjes <rientjes@google.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [BUGFIX][PATCH -mmotm] memcg: avoid oom-killing innocent task in case of use_hierarchy
Date: Wed, 25 Nov 2009 09:39:33 +0530 [thread overview]
Message-ID: <20091125040933.GE3365@balbir.in.ibm.com> (raw)
In-Reply-To: <20091124145759.194cfc9f.nishimura@mxp.nes.nec.co.jp>
* nishimura@mxp.nes.nec.co.jp <nishimura@mxp.nes.nec.co.jp> [2009-11-24 14:57:59]:
> task_in_mem_cgroup(), which is called by select_bad_process() to check whether
> a task can be a candidate for being oom-killed from memcg's limit, checks
> "curr->use_hierarchy"("curr" is the mem_cgroup the task belongs to).
>
> But this check return true(it's false positive) when:
>
> <some path>/00 use_hierarchy == 0 <- hitting limit
> <some path>/00/aa use_hierarchy == 1 <- "curr"
>
> This leads to killing an innocent task in 00/aa. This patch is a fix for this
> bug. And this patch also fixes the arg for mem_cgroup_print_oom_info(). We
> should print information of mem_cgroup which the task being killed, not current,
> belongs to.
>
> Signed-off-by: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>
--
Balbir
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2009-11-25 4:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-24 5:57 [BUGFIX][PATCH -mmotm] memcg: avoid oom-killing innocent task in case of use_hierarchy Daisuke Nishimura
2009-11-24 7:28 ` [BUGFIX][PATCH -stable] " Daisuke Nishimura
2009-11-25 0:00 ` KAMEZAWA Hiroyuki
2009-11-25 5:32 ` [BUGFIX][PATCH v2 " Daisuke Nishimura
2009-11-25 5:50 ` KAMEZAWA Hiroyuki
2009-11-25 20:45 ` Andrew Morton
2009-11-26 0:11 ` [BUGFIX][PATCH v2 -mmotm] " Daisuke Nishimura
2009-12-17 0:47 ` [BUGFIX][PATCH v2 -stable] " Daisuke Nishimura
2010-01-04 22:28 ` [stable] " Greg KH
2010-01-05 3:26 ` [stable][BUGFIX][PATCH v3] " Daisuke Nishimura
2010-01-05 19:26 ` [stable] [BUGFIX][PATCH " Greg KH
2010-01-05 19:33 ` patch memcg-avoid-oom-killing-innocent-task-in-case-of-use_hierarchy.patch added to 2.6.31-stable tree gregkh
2009-11-25 4:08 ` [BUGFIX][PATCH -stable] memcg: avoid oom-killing innocent task in case of use_hierarchy Balbir Singh
2009-11-24 13:31 ` [BUGFIX][PATCH -mmotm] " Balbir Singh
2009-11-24 14:00 ` Daisuke Nishimura
2009-11-24 17:04 ` Balbir Singh
2009-11-24 23:49 ` Daisuke Nishimura
2009-11-25 3:29 ` Balbir Singh
2009-11-25 0:07 ` KAMEZAWA Hiroyuki
2009-11-25 4:09 ` Balbir Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091125040933.GE3365@balbir.in.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=rientjes@google.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).