Re: [RFC mm][PATCH 1/5] mm counter cleanup

KAMEZAWA Hiroyuki
2009-12-10T23:46:19Z

On Thu, 10 Dec 2009 11:30:46 -0600 (CST)
Christoph Lameter <cl@linux-foundation.org> wrote:

> On Thu, 10 Dec 2009, KAMEZAWA Hiroyuki wrote:
>
> > This patch modifies it to
> > - Define them in mm.h as inline functions
> > - Use array instead of macro's name creation. For making easier to add
> > new coutners.
>
> Reviewed-by: Christoph Lameter <cl@linux-foundation.org>
>
> > @@ -454,8 +456,8 @@ static struct mm_struct * mm_init(struct
> > (current->mm->flags & MMF_INIT_MASK) : default_dump_filter;
> > mm->core_state = NULL;
> > mm->nr_ptes = 0;
> > - set_mm_counter(mm, file_rss, 0);
> > - set_mm_counter(mm, anon_rss, 0);
> > + for (i = 0; i < NR_MM_COUNTERS; i++)
> > + set_mm_counter(mm, i, 0);
>
>
> memset? Or add a clear_mm_counter function? This also occurred earlier in
> init_rss_vec().
>
Ok, I'll try some cleaner codes.

Thanks,
-Kame