From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with ESMTP id D0D5C60044A for ; Sun, 3 Jan 2010 19:15:26 -0500 (EST) Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58]) by e28smtp06.in.ibm.com (8.14.3/8.13.1) with ESMTP id o040FLnA003644 for ; Mon, 4 Jan 2010 05:45:21 +0530 Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o040FLpZ2412602 for ; Mon, 4 Jan 2010 05:45:21 +0530 Received: from d28av05.in.ibm.com (loopback [127.0.0.1]) by d28av05.in.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o040FLRX022552 for ; Mon, 4 Jan 2010 11:15:21 +1100 Date: Mon, 4 Jan 2010 05:45:16 +0530 From: Balbir Singh Subject: Re: [PATCH v4 0/4] cgroup notifications API and memory thresholds Message-ID: <20100104001516.GE16187@balbir.in.ibm.com> Reply-To: balbir@linux.vnet.ibm.com References: <20091227124732.GA3601@balbir.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: owner-linux-mm@kvack.org To: "Kirill A. Shutemov" Cc: containers@lists.linux-foundation.org, linux-mm@kvack.org, Paul Menage , Li Zefan , Andrew Morton , KAMEZAWA Hiroyuki , Pavel Emelyanov , Dan Malek , Vladislav Buzov , Daisuke Nishimura , Alexander Shishkin , linux-kernel@vger.kernel.org List-ID: * Kirill A. Shutemov [2009-12-27 20:37:57]: > On Sun, Dec 27, 2009 at 2:47 PM, Balbir Singh wrote: > > * Kirill A. Shutemov [2009-12-27 04:08:58]: > > > >> This patchset introduces eventfd-based API for notifications in cgroups and > >> implements memory notifications on top of it. > >> > >> It uses statistics in memory controler to track memory usage. > >> > >> Output of time(1) on building kernel on tmpfs: > >> > >> Root cgroup before changes: > >> make -j2 506.37 user 60.93s system 193% cpu 4:52.77 total > >> Non-root cgroup before changes: > >> make -j2 507.14 user 62.66s system 193% cpu 4:54.74 total > >> Root cgroup after changes (0 thresholds): > >> make -j2 507.13 user 62.20s system 193% cpu 4:53.55 total > >> Non-root cgroup after changes (0 thresholds): > >> make -j2 507.70 user 64.20s system 193% cpu 4:55.70 total > >> Root cgroup after changes (1 thresholds, never crossed): > >> make -j2 506.97 user 62.20s system 193% cpu 4:53.90 total > >> Non-root cgroup after changes (1 thresholds, never crossed): > >> make -j2 507.55 user 64.08s system 193% cpu 4:55.63 total > >> > >> Any comments? > > > > Thanks for adding the documentation, now on to more critical questions > > > > 1. Any reasons for not using cgroupstats? > > Could you explain the idea? I don't see how cgroupstats applicable for > the task. cgroupstats allows you to notify task statistics or send notifications, hence the applicability. > > > 2. Is there a user space test application to test this code. > > Attached. It's not very clean, but good enough for testing propose. > Example of usage: > > $ echo '/cgroups/memory.usage_in_bytes 1G' | ./cgroup_event_monitor > Thanks, I'll test it right now. > > IIUC, > > I need to write a program that uses eventfd(2) and then passes > > the eventfd descriptor and thresold to cgroup.*event* file and > > then the program will get notified when the threshold is reached? > > You need to pass eventfd descriptor, descriptor of control file to be > monitored (memory.usage_in_bytes or memory.memsw.usage_in_bytes) and > threshold. > > Do you want to rename cgroup.event_control to cgroup.event? No, event_control seems like a good name ATM. -- Balbir -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org