From: Eric B Munson <ebmunson@us.ibm.com>
To: Hugh Dickins <hugh.dickins@tiscali.co.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@ZenIV.linux.org.uk>,
David Howells <dhowells@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm: move sys_mmap_pgoff from util.c
Date: Mon, 4 Jan 2010 12:38:58 +0000 [thread overview]
Message-ID: <20100104123858.GA5045@us.ibm.com> (raw)
In-Reply-To: <alpine.LSU.2.00.0912302009040.30390@sister.anvils>
[-- Attachment #1: Type: text/plain, Size: 694 bytes --]
On Wed, 30 Dec 2009, Hugh Dickins wrote:
> Move sys_mmap_pgoff() from mm/util.c to mm/mmap.c and mm/nommu.c,
> where we'd expect to find such code: especially now that it contains
> the MAP_HUGETLB handling. Revert mm/util.c to how it was in 2.6.32.
>
> This patch just ignores MAP_HUGETLB in the nommu case, as in 2.6.32,
> whereas 2.6.33-rc2 reported -ENOSYS. Perhaps validate_mmap_request()
> should reject it with -EINVAL? Add that later if necessary.
>
> Signed-off-by: Hugh Dickins <hugh.dickins@tiscali.co.uk>
I think that -ENOSYS is the correcet response in the nommu case, but
I that can be added in a later patch.
Acked-by: Eric B Munson <ebmunson@us.ibm.com>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2010-01-04 12:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-30 20:17 [PATCH] mm: move sys_mmap_pgoff from util.c Hugh Dickins
2010-01-04 12:38 ` Eric B Munson [this message]
2010-01-04 17:21 ` Hugh Dickins
2010-01-05 12:37 ` [PATCH] nommu: reject MAP_HUGETLB Hugh Dickins
2010-01-05 12:47 ` Eric B Munson
2010-01-05 15:23 ` David Howells
2010-01-05 16:16 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100104123858.GA5045@us.ibm.com \
--to=ebmunson@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=hugh.dickins@tiscali.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).