From: Andi Kleen <andi@firstfloor.org>
To: David Rientjes <rientjes@google.com>
Cc: Andi Kleen <andi@firstfloor.org>,
submit@firstfloor.org, linux-kernel@vger.kernel.org,
haicheng.li@intel.com, Pekka Enberg <penberg@cs.helsinki.fi>,
linux-mm@kvack.org
Subject: Re: [PATCH] [1/4] SLAB: Handle node-not-up case in fallback_alloc()
Date: Sat, 6 Feb 2010 08:25:08 +0100 [thread overview]
Message-ID: <20100206072508.GN29555@one.firstfloor.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1002051251390.2376@chino.kir.corp.google.com>
On Fri, Feb 05, 2010 at 01:06:56PM -0800, David Rientjes wrote:
> On Wed, 3 Feb 2010, Andi Kleen wrote:
>
> > When fallback_alloc() runs the node of the CPU might not be initialized yet.
> > Handle this case by allocating in another node.
> >
>
> That other node must be allowed by current's cpuset, otherwise
> kmem_getpages() will fail when get_page_from_freelist() iterates only over
> unallowed nodes.
All theses cases are really only interesting in the memory hotplug path
itself (afterwards the slab is working anyways and memory is there)
and if someone sets funny cpusets for those he gets what he deserves ...
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-02-06 7:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-03 21:39 [PATCH] [0/4] SLAB: Fix a couple of slab memory hotadd issues Andi Kleen
2010-02-03 21:39 ` [PATCH] [1/4] SLAB: Handle node-not-up case in fallback_alloc() Andi Kleen
2010-02-05 21:06 ` David Rientjes
2010-02-06 7:25 ` Andi Kleen [this message]
2010-02-06 9:53 ` David Rientjes
2010-02-06 15:56 ` Andi Kleen
2010-02-06 22:31 ` David Rientjes
2010-02-03 21:39 ` [PATCH] [2/4] SLAB: Set up the l3 lists for the memory of freshly added memory Andi Kleen
2010-02-05 19:12 ` Christoph Lameter
2010-02-05 21:17 ` David Rientjes
2010-02-06 7:26 ` Andi Kleen
2010-02-06 9:47 ` David Rientjes
2010-02-03 21:39 ` [PATCH] [3/4] SLAB: Separate node initialization into separate function Andi Kleen
2010-02-05 19:15 ` Christoph Lameter
2010-02-05 21:29 ` David Rientjes
2010-02-06 7:27 ` Andi Kleen
2010-02-06 9:55 ` David Rientjes
2010-02-03 21:39 ` [PATCH] [4/4] SLAB: Fix node add timer race in cache_reap Andi Kleen
2010-02-05 19:16 ` Christoph Lameter
2010-02-05 8:27 ` [PATCH] [0/4] SLAB: Fix a couple of slab memory hotadd issues Pekka Enberg
2010-02-05 19:19 ` Christoph Lameter
2010-02-05 20:22 ` Andi Kleen
2010-02-05 20:55 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100206072508.GN29555@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=haicheng.li@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
--cc=rientjes@google.com \
--cc=submit@firstfloor.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).