From: aarcange@redhat.com
To: linux-mm@kvack.org
Cc: Andrea Arcangeli <aarcange@redhat.com>, Rik van Riel <riel@redhat.com>
Subject: [patch 29/35] verify pmd_trans_huge isnt leaking
Date: Fri, 26 Feb 2010 21:05:02 +0100 [thread overview]
Message-ID: <20100226200903.521314484@redhat.com> (raw)
In-Reply-To: 20100226200433.516502198@redhat.com
[-- Attachment #1: debug_pte_trans_huge --]
[-- Type: text/plain, Size: 1607 bytes --]
From: Andrea Arcangeli <aarcange@redhat.com>
pte_trans_huge must not leak in certain vmas like the mmio special pfn or
filebacked mappings.
Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
Acked-by: Rik van Riel <riel@redhat.com>
---
mm/memory.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -1423,6 +1423,7 @@ int __get_user_pages(struct task_struct
pmd = pmd_offset(pud, pg);
if (pmd_none(*pmd))
return i ? : -EFAULT;
+ VM_BUG_ON(pmd_trans_huge(*pmd));
pte = pte_offset_map(pmd, pg);
if (pte_none(*pte)) {
pte_unmap(pte);
@@ -1624,8 +1625,10 @@ pte_t *get_locked_pte(struct mm_struct *
pud_t * pud = pud_alloc(mm, pgd, addr);
if (pud) {
pmd_t * pmd = pmd_alloc(mm, pud, addr);
- if (pmd)
+ if (pmd) {
+ VM_BUG_ON(pmd_trans_huge(*pmd));
return pte_alloc_map_lock(mm, pmd, addr, ptl);
+ }
}
return NULL;
}
@@ -1844,6 +1847,7 @@ static inline int remap_pmd_range(struct
pmd = pmd_alloc(mm, pud, addr);
if (!pmd)
return -ENOMEM;
+ VM_BUG_ON(pmd_trans_huge(*pmd));
do {
next = pmd_addr_end(addr, end);
if (remap_pte_range(mm, pmd, addr, next,
@@ -3319,6 +3323,7 @@ static int follow_pte(struct mm_struct *
goto out;
pmd = pmd_offset(pud, address);
+ VM_BUG_ON(pmd_trans_huge(*pmd));
if (pmd_none(*pmd) || unlikely(pmd_bad(*pmd)))
goto out;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-02-26 20:09 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-26 20:04 [patch 00/35] Transparent Hugepage support #12 aarcange
2010-02-26 20:04 ` [patch 01/35] define MADV_HUGEPAGE aarcange
2010-02-26 20:04 ` [patch 02/35] compound_lock aarcange
2010-02-26 20:04 ` [patch 03/35] alter compound get_page/put_page aarcange
2010-02-26 20:04 ` [patch 04/35] update futex compound knowledge aarcange
2010-02-26 20:04 ` [patch 05/35] fix bad_page to show the real reason the page is bad aarcange
2010-02-26 20:04 ` [patch 06/35] clear compound mapping aarcange
2010-02-26 20:04 ` [patch 07/35] add native_set_pmd_at aarcange
2010-02-26 20:04 ` [patch 08/35] add pmd paravirt ops aarcange
2010-02-26 20:04 ` [patch 09/35] no paravirt version of pmd ops aarcange
2010-02-26 20:04 ` [patch 10/35] export maybe_mkwrite aarcange
2010-02-26 20:04 ` [patch 11/35] comment reminder in destroy_compound_page aarcange
2010-02-26 20:04 ` [patch 12/35] config_transparent_hugepage aarcange
2010-02-26 20:04 ` [patch 13/35] special pmd_trans_* functions aarcange
2010-02-26 20:04 ` [patch 14/35] add pmd mangling generic functions aarcange
2010-02-26 20:04 ` [patch 15/35] add pmd mangling functions to x86 aarcange
2010-02-26 20:04 ` [patch 16/35] bail out gup_fast on splitting pmd aarcange
2010-02-26 20:04 ` [patch 17/35] pte alloc trans splitting aarcange
2010-02-26 20:04 ` [patch 18/35] add pmd mmu_notifier helpers aarcange
2010-02-26 20:04 ` [patch 19/35] clear page compound aarcange
2010-02-26 20:04 ` [patch 20/35] add pmd_huge_pte to mm_struct aarcange
2010-02-26 20:04 ` [patch 21/35] split_huge_page_mm/vma aarcange
2010-02-26 20:04 ` [patch 22/35] split_huge_page paging aarcange
2010-02-26 20:04 ` [patch 23/35] clear_copy_huge_page aarcange
2010-02-26 20:04 ` [patch 24/35] kvm mmu transparent hugepage support aarcange
2010-02-26 20:04 ` [patch 25/35] _GFP_NO_KSWAPD aarcange
2010-02-26 20:04 ` [patch 26/35] dont alloc harder for gfp nomemalloc even if nowait aarcange
2010-02-26 20:05 ` [patch 27/35] transparent hugepage core aarcange
2010-02-26 20:05 ` [patch 28/35] adapt to mm_counter in -mm aarcange
2010-02-26 20:05 ` aarcange [this message]
2010-02-26 20:05 ` [patch 30/35] madvise(MADV_HUGEPAGE) aarcange
2010-02-26 20:05 ` [patch 31/35] pmd_trans_huge migrate bugcheck aarcange
2010-02-26 20:05 ` [patch 32/35] memcg compound aarcange
2010-02-26 20:05 ` [patch 33/35] memcg huge memory aarcange
2010-02-26 20:05 ` [patch 34/35] transparent hugepage vmstat aarcange
2010-02-26 20:05 ` [patch 35/35] khugepaged aarcange
-- strict thread matches above, loose matches on Subject: below --
2010-03-09 19:39 [patch 00/35] Transparent Hugepage support #13 aarcange
2010-03-09 19:39 ` [patch 29/35] verify pmd_trans_huge isnt leaking aarcange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100226200903.521314484@redhat.com \
--to=aarcange@redhat.com \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).