linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Christian Ehrhardt <uni@c--e.de>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Rik van Riel <riel@redhat.com>, Christian Ehrhardt <lk@c--e.de>,
	linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	linux-mm@kvack.org
Subject: Re: [PATCH] rmap: Fix Bugzilla Bug #5493
Date: Sat, 6 Mar 2010 15:44:22 +0100	[thread overview]
Message-ID: <20100306144422.GI17078@lisa.in-ulm.de> (raw)
In-Reply-To: <20100306020048.GA16967@cmpxchg.org>


Hi,

On Sat, Mar 06, 2010 at 03:00:48AM +0100, Johannes Weiner wrote:
> What's with expand_stack()?  This changes the radix index or the heap
> index, depending on the direction in which the stack grows, but it
> does not adjust the tree and so its order is violated.  Did you make
> sure that this is fine?

Ooops! Thanks for the hint. Not only expand stack but also vma_adjust
(aka vma_merge) need to update the tree, I guess.

However, it is somewhat odd that this did not trigger anything in
my tests. I guess I have to come up with a testcase that properly
checks this case.

      regards   Christian

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2010-03-06 14:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-05  9:38 [PATCH] rmap: Fix Bugzilla Bug #5493 Christian Ehrhardt
2010-03-05 14:10 ` Rik van Riel
2010-03-06  1:02   ` Christian Ehrhardt
2010-03-06  2:00     ` Johannes Weiner
2010-03-06 14:44       ` Christian Ehrhardt [this message]
2010-03-06  1:35 ` Kyle McMartin
2010-03-06  9:24 ` Mikael Pettersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100306144422.GI17078@lisa.in-ulm.de \
    --to=uni@c--e.de \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lk@c--e.de \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).